Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1751)

Unified Diff: content/common/gpu/media/v4l2_video_decode_accelerator.cc

Issue 1696303003: V4L2VDA: Always check V4L2_EVENT_SRC_CH_RESOLUTION bit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/media/v4l2_video_decode_accelerator.cc
diff --git a/content/common/gpu/media/v4l2_video_decode_accelerator.cc b/content/common/gpu/media/v4l2_video_decode_accelerator.cc
index f9311257ed70cbf3c78ba7adf4da9805a5f0736e..d58ecde8d07359416ff10eb5f6bdefcc2ae98b5c 100644
--- a/content/common/gpu/media/v4l2_video_decode_accelerator.cc
+++ b/content/common/gpu/media/v4l2_video_decode_accelerator.cc
@@ -1023,14 +1023,7 @@ bool V4L2VideoDecodeAccelerator::DequeueResolutionChangeEvent() {
while (device_->Ioctl(VIDIOC_DQEVENT, &ev) == 0) {
if (ev.type == V4L2_EVENT_SOURCE_CHANGE) {
- uint32_t changes = ev.u.src_change.changes;
- // We used to define source change was always resolution change. The union
- // |ev.u| is not used and it is zero by default. When using the upstream
- // version of the resolution event change, we also need to check
- // |ev.u.src_change.changes| to know what is changed. For API backward
- // compatibility, event is treated as resolution change when all bits in
- // |ev.u.src_change.changes| are cleared.
- if (changes == 0 || (changes & V4L2_EVENT_SRC_CH_RESOLUTION)) {
+ if (ev.u.src_change.changes & V4L2_EVENT_SRC_CH_RESOLUTION) {
DVLOG(3)
<< "DequeueResolutionChangeEvent(): got resolution change event.";
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698