Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1696263002: X87: [Interpreter] Make InterpreterAssembler a subclass of CodeStubAssembler. (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Make InterpreterAssembler a subclass of CodeStubAssembler. port d1c28849c77892ec74e58891aba44d5bfda8c0ba(r33873) original commit message: Moves InterpreterAssembler out of the compiler directory and into the interpreter directory. Makes InterpreterAssembler as subclass of CodeStubAssembler. As part of this change, the special bytecode dispatch linkage type is removed and instead we use a InterfaceDispatchDescriptor and a normal CodeStub linkage type. Removes a bunch of duplicated logic in InterpreterAssembler and instead uses the CodeStubAssembler logic. Refactors Interpreter with these changes. Modifies CodeStubAssembler to add the extra operations required by the Interpreter (extra call types, raw memory access and some extra binary ops). Also adds the ability for subclasses to add extra prologue and epilogue operations around calls, which is required for the Interpreter. BUG= Committed: https://crrev.com/8c3a00ad4391bf2a32a82a246804181d7816750b Cr-Commit-Position: refs/heads/master@{#34011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/x87/interface-descriptors-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-16 03:12:43 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-16 04:30:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696263002/1
4 years, 10 months ago (2016-02-16 04:33:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 04:51:28 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 04:52:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c3a00ad4391bf2a32a82a246804181d7816750b
Cr-Commit-Position: refs/heads/master@{#34011}

Powered by Google App Engine
This is Rietveld 408576698