Make render pipeline throttling opt-in

Make render pipeline throttling opt-in

Previously render pipeline throttling was allowed by default, and
subsystems which did not want throttling to happen needed to use
DocumentLifecycle::PreventThrottlingScope to turn it off. This was
error-prone and dangerous since it meant callers might see out-of-date
layout and style information unless they knew to opt out.

This patch flips the default to be that throttling is disallowed unless
DocumentLifecycle::AllowThrottlingScope is used to turn it on. We now
explicitly enable throttling for animations, lifecycle updates and hit
testing.

BUG=487937
Committed: https://crrev.com/324897d72015abb00a5f7c682fbdc2e5d82619b0
Cr-Commit-Position: refs/heads/master@{#376024}

[Sami, 2016-02-15 19:26:12]

Description was changed from

==========
Make render pipeline throttling opt-in

Previously render pipeline throttling was allowed by default, and
subsystems which did not want throttling to happen needed to use
DocumentLifecycle::PreventThrottlingScope to turn it off. This was
error-prone and dangerous since it meant callers might see out-of-date
layout and style information unless they knew to opt out.

This patch flips the default to be that throttling is disallowed unless
DocumentLifecycle::PreventThrottlingScope is used to turn it on. We now
explicitly enable throttling for animations, lifecycle updates and hit
testing.

BUG=487937
==========

to

==========
Make render pipeline throttling opt-in

Previously render pipeline throttling was allowed by default, and
subsystems which did not want throttling to happen needed to use
DocumentLifecycle::PreventThrottlingScope to turn it off. This was
error-prone and dangerous since it meant callers might see out-of-date
layout and style information unless they knew to opt out.

This patch flips the default to be that throttling is disallowed unless
DocumentLifecycle::AllowThrottlingScope is used to turn it on. We now
explicitly enable throttling for animations, lifecycle updates and hit
testing.

BUG=487937
==========

[Sami, 2016-02-15 19:26:58]

skyostil@chromium.org changed reviewers:
+ esprehn@chromium.org, hayato@chromium.org, ojan@chromium.org,
tkent@chromium.org

[tkent, 2016-02-15 23:31:36]

This looks very reasonable.

[hayato, 2016-02-16 02:27:07]

Thank you for working on this change! lgtm

[Sami, 2016-02-17 14:36:14]

Thanks! Elliott and/or Ojan, WDYT?

[esprehn, 2016-02-17 19:01:05]

lgtm

[esprehn, 2016-02-17 19:01:38]

lgtm, great! I think over time we'll find new places where we can add
AllowThrottlingScope, but this is a good improvement and is a safe place to
start.

[esprehn, 2016-02-17 19:01:54]

The CQ bit was checked by esprehn@chromium.org

[esprehn, 2016-02-17 19:01:54]

The patchset sent to the CQ was uploaded after l-g-t-m from hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/1696233002/#ps60001
(title: "Windows build fix.")

[commit-bot: I haz the power, 2016-02-17 19:04:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1696233002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1696233002/60001

[commit-bot: I haz the power, 2016-02-17 23:19:28]

Description was changed from

==========
Make render pipeline throttling opt-in

Previously render pipeline throttling was allowed by default, and
subsystems which did not want throttling to happen needed to use
DocumentLifecycle::PreventThrottlingScope to turn it off. This was
error-prone and dangerous since it meant callers might see out-of-date
layout and style information unless they knew to opt out.

This patch flips the default to be that throttling is disallowed unless
DocumentLifecycle::AllowThrottlingScope is used to turn it on. We now
explicitly enable throttling for animations, lifecycle updates and hit
testing.

BUG=487937
==========

to

==========
Make render pipeline throttling opt-in

Previously render pipeline throttling was allowed by default, and
subsystems which did not want throttling to happen needed to use
DocumentLifecycle::PreventThrottlingScope to turn it off. This was
error-prone and dangerous since it meant callers might see out-of-date
layout and style information unless they knew to opt out.

This patch flips the default to be that throttling is disallowed unless
DocumentLifecycle::AllowThrottlingScope is used to turn it on. We now
explicitly enable throttling for animations, lifecycle updates and hit
testing.

BUG=487937
==========

[commit-bot: I haz the power, 2016-02-17 23:19:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-17 23:20:35]

Description was changed from

==========
Make render pipeline throttling opt-in

Previously render pipeline throttling was allowed by default, and
subsystems which did not want throttling to happen needed to use
DocumentLifecycle::PreventThrottlingScope to turn it off. This was
error-prone and dangerous since it meant callers might see out-of-date
layout and style information unless they knew to opt out.

This patch flips the default to be that throttling is disallowed unless
DocumentLifecycle::AllowThrottlingScope is used to turn it on. We now
explicitly enable throttling for animations, lifecycle updates and hit
testing.

BUG=487937
==========

to

==========
Make render pipeline throttling opt-in

Previously render pipeline throttling was allowed by default, and
subsystems which did not want throttling to happen needed to use
DocumentLifecycle::PreventThrottlingScope to turn it off. This was
error-prone and dangerous since it meant callers might see out-of-date
layout and style information unless they knew to opt out.

This patch flips the default to be that throttling is disallowed unless
DocumentLifecycle::AllowThrottlingScope is used to turn it on. We now
explicitly enable throttling for animations, lifecycle updates and hit
testing.

BUG=487937

Committed: https://crrev.com/324897d72015abb00a5f7c682fbdc2e5d82619b0
Cr-Commit-Position: refs/heads/master@{#376024}
==========

[commit-bot: I haz the power, 2016-02-17 23:20:36]

Patchset 4 (id:??) landed as
https://crrev.com/324897d72015abb00a5f7c682fbdc2e5d82619b0
Cr-Commit-Position: refs/heads/master@{#376024}

[Łukasz Anforowicz, 2016-02-18 18:16:50]

On 2016/02/17 23:20:36, commit-bot: I haz the power wrote:
> Patchset 4 (id:??) landed as
> https://crrev.com/324897d72015abb00a5f7c682fbdc2e5d82619b0
> Cr-Commit-Position: refs/heads/master@{#376024}

This made site-isolation FYI bot red - please see crbug.com/587909.