Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_test.dart

Issue 1696193003: Fix cache corruption in incremental resolver (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: post-review cleanup Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/summary/resynthesize_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_test.dart b/pkg/analyzer/test/src/summary/resynthesize_test.dart
index 3f6d6536ee097af4b7f4f35e66965121933a6fac..35a9bfc056dbd7db976209b7406f96f95cca394f 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_test.dart
@@ -534,12 +534,19 @@ class ResynthTest extends ResolverTestCase {
compareMetadata(resynthesized.metadata, original.metadata, desc);
// Modifiers are a pain to test via handles. So just test them via the
// actual element.
- for (Modifier modifier in Modifier.values) {
+ for (Modifier modifier in Modifier.persistedValues) {
bool got = rImpl.hasModifier(modifier);
bool want = oImpl.hasModifier(modifier);
expect(got, want,
reason: 'Mismatch in $desc.$modifier: got $got, want $want');
}
+ for (Modifier modifier in Modifier.transientValues) {
+ bool got = rImpl.hasModifier(modifier);
+ bool want = false;
+ expect(got, false,
+ reason: 'Mismatch in $desc.$modifier: got $got, want $want');
+ }
+
// Validate members.
if (oImpl is Member) {
expect(rImpl, new isInstanceOf<Member>(), reason: desc);

Powered by Google App Engine
This is Rietveld 408576698