Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart

Issue 1696193003: Fix cache corruption in incremental resolver (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: post-review cleanup Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
diff --git a/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart b/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
index f0f7a4c7cb14f5666bcfcc075e4c2e253310d7db..cf2c0dda5cd198ab6f1412d4eaf4b236f221d02f 100644
--- a/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
+++ b/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
@@ -28,10 +28,15 @@ void assertSameResolution(CompilationUnit actual, CompilationUnit expected,
class IncrementalResolutionMismatch {
final String message;
IncrementalResolutionMismatch(this.message);
+
+ @override
+ String toString() => "IncrementalResolutionMismatch: $message";
}
class _SameResolutionValidator implements AstVisitor {
final bool validateTypes;
+
+ /// The expected node to compare with the visted node.
AstNode other;
_SameResolutionValidator(this.validateTypes, this.other);
@@ -887,11 +892,11 @@ class _SameResolutionValidator implements AstVisitor {
_assertNode(a, b);
}
- void _visitList(NodeList nodeList, NodeList otherList) {
+ void _visitList(NodeList nodeList, NodeList expected) {
int length = nodeList.length;
- _expectLength(otherList, length);
+ _expectLength(nodeList, expected.length);
for (int i = 0; i < length; i++) {
- _visitNode(nodeList[i], otherList[i]);
+ _visitNode(nodeList[i], expected[i]);
}
}

Powered by Google App Engine
This is Rietveld 408576698