Fix cache corruption in incremental resolver

pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart

Index: pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
diff --git a/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart b/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
index f0f7a4c7cb14f5666bcfcc075e4c2e253310d7db..25c0b847cfc6e22d831ab3591543fd9262547ddb 100644
--- a/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
+++ b/pkg/analyzer/lib/src/generated/incremental_resolution_validator.dart
@@ -28,11 +28,14 @@ void assertSameResolution(CompilationUnit actual, CompilationUnit expected,
 class IncrementalResolutionMismatch {
   final String message;
   IncrementalResolutionMismatch(this.message);
+
+  @override
+  String toString() => "IncrementalResolutionMismatch: $message";
 }
 
 class _SameResolutionValidator implements AstVisitor {
   final bool validateTypes;
-  AstNode other;
+  AstNode other; // expected

[Brian Wilkerson, 2016/02/16 15:10:48]

nit: the comment should be a dartdoc

[skybrian, 2016/02/17 01:23:41]

Done. (Actually the variable should be renamed, but I won't do that now.)

 
   _SameResolutionValidator(this.validateTypes, this.other);
 
@@ -887,11 +890,11 @@ class _SameResolutionValidator implements AstVisitor {
     _assertNode(a, b);
   }
 
-  void _visitList(NodeList nodeList, NodeList otherList) {
+  void _visitList(NodeList nodeList, NodeList expected) {
     int length = nodeList.length;
-    _expectLength(otherList, length);
+    _expectLength(nodeList, expected.length);
     for (int i = 0; i < length; i++) {
-      _visitNode(nodeList[i], otherList[i]);
+      _visitNode(nodeList[i], expected[i]);
     }
   }