Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 1696173002: Add new OWNERS and remove drover.properties. (Closed)

Created:
4 years, 10 months ago by kjellander_chromium
Modified:
4 years, 10 months ago
CC:
magjed_chromium, torbjorng
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add new OWNERS and remove drover.properties. The drover.properties file is no longer useful after migrating the repo to Git. BUG=libyuv:568 R=mflodman@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/f9496cfdf3e666c593ea1001f75252a5e3964d92

Patch Set 1 #

Total comments: 2

Patch Set 2 : Converted to unix line endings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M OWNERS View 1 1 chunk +13 lines, -2 lines 0 comments Download
D drover.properties View 1 chunk +0 lines, -6 lines 0 comments Download
A + tools/OWNERS View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_chromium
https://codereview.chromium.org/1696173002/diff/1/OWNERS File OWNERS (left): https://codereview.chromium.org/1696173002/diff/1/OWNERS#oldcode2 OWNERS:2: mflodman@chromium.org I assumed mflodman is no longer useful as ...
4 years, 10 months ago (2016-02-15 14:54:54 UTC) #2
kjellander_chromium
I meant to add mflodman@chromium.org as reviwer. Fixed now.
4 years, 10 months ago (2016-02-15 15:02:56 UTC) #6
mflodman_chromium_OOO
lgtm https://codereview.chromium.org/1696173002/diff/1/OWNERS File OWNERS (left): https://codereview.chromium.org/1696173002/diff/1/OWNERS#oldcode2 OWNERS:2: mflodman@chromium.org On 2016/02/15 14:54:54, kjellander (chromium) wrote: > ...
4 years, 10 months ago (2016-02-15 15:49:59 UTC) #7
fbarchard1
On 2016/02/15 15:49:59, mflodman_chromium_OOO wrote: > lgtm > > https://codereview.chromium.org/1696173002/diff/1/OWNERS > File OWNERS (left): > ...
4 years, 10 months ago (2016-02-16 18:17:25 UTC) #8
kjellander_chromium
4 years, 10 months ago (2016-02-16 18:53:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f9496cfdf3e666c593ea1001f75252a5e3964d92 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698