Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: src/IceTargetLowering.cpp

Issue 1696123003: Subzero: Set the correct target arch in the browser hookup. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Better bad-target error messages Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/IceBrowserCompileServer.cpp ('K') | « src/IceBrowserCompileServer.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLowering.cpp
diff --git a/src/IceTargetLowering.cpp b/src/IceTargetLowering.cpp
index 9f05017f4c5c77a4b67062be9f94ba6385f7d5f1..c696ba6dc063d7fbfc2cd4b34955e9ac56b6eb37 100644
--- a/src/IceTargetLowering.cpp
+++ b/src/IceTargetLowering.cpp
@@ -154,6 +154,11 @@ void splitToClassAndName(const IceString &RegName, IceString *SplitRegClass,
}
}
+LLVM_ATTRIBUTE_NORETURN void badTargetFatalError(TargetArch Target) {
+ llvm::report_fatal_error("Unsupported target: " +
+ std::string(targetArchString(Target)));
+}
+
} // end of anonymous namespace
void TargetLowering::filterTypeToRegisterSet(
@@ -243,7 +248,7 @@ std::unique_ptr<TargetLowering>
TargetLowering::createLowering(TargetArch Target, Cfg *Func) {
switch (Target) {
default:
- llvm::report_fatal_error("Unsupported target");
+ badTargetFatalError(Target);
#define SUBZERO_TARGET(X) \
case Target_##X: \
return ::X::createTargetLowering(Func);
@@ -257,7 +262,7 @@ void TargetLowering::staticInit(GlobalContext *Ctx) {
// Call the specified target's static initializer.
switch (Target) {
default:
- llvm::report_fatal_error("Unsupported target");
+ badTargetFatalError(Target);
#define SUBZERO_TARGET(X) \
case Target_##X: { \
static bool InitGuard##X = false; \
@@ -742,7 +747,7 @@ TargetDataLowering::createLowering(GlobalContext *Ctx) {
TargetArch Target = Ctx->getFlags().getTargetArch();
switch (Target) {
default:
- llvm::report_fatal_error("Unsupported target");
+ badTargetFatalError(Target);
#define SUBZERO_TARGET(X) \
case Target_##X: \
return ::X::createTargetDataLowering(Ctx);
@@ -874,7 +879,7 @@ TargetHeaderLowering::createLowering(GlobalContext *Ctx) {
TargetArch Target = Ctx->getFlags().getTargetArch();
switch (Target) {
default:
- llvm::report_fatal_error("Unsupported target");
+ badTargetFatalError(Target);
#define SUBZERO_TARGET(X) \
case Target_##X: \
return ::X::createTargetHeaderLowering(Ctx);
« src/IceBrowserCompileServer.cpp ('K') | « src/IceBrowserCompileServer.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698