Subzero: Set the correct target arch in the browser hookup.

Subzero: Set the correct target arch in the browser hookup.

The original implementation hard-coded the target to x86-32.

The new implementation mirrors pnacl-llc by probing the architecture it is running on.

Continues the plumbing work in https://codereview.chromium.org/1698523003/ , toward the goal of enabling sandboxed translator tests for x86-64, particularly on the spec bots.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4077
R=jpp@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=816fd68fef0608236fc3fe0c2ce313c14487e3a6

[Jim Stichnoth, 2016-02-15 19:59:24]

Description was changed from

==========
Subzero: Set the correct target arch in the browser hookup.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4077
==========

to

==========
Subzero: Set the correct target arch in the browser hookup.

The original implementation hard-coded the target to x86-32.

The new implementation mirrors pnacl-llc by probing the architecture it is
running on.

Continues the plumbing work in https://codereview.chromium.org/1698523003/ .

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4077
==========

[Jim Stichnoth, 2016-02-15 20:24:29]

Description was changed from

==========
Subzero: Set the correct target arch in the browser hookup.

The original implementation hard-coded the target to x86-32.

The new implementation mirrors pnacl-llc by probing the architecture it is
running on.

Continues the plumbing work in https://codereview.chromium.org/1698523003/ .

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4077
==========

to

==========
Subzero: Set the correct target arch in the browser hookup.

The original implementation hard-coded the target to x86-32.

The new implementation mirrors pnacl-llc by probing the architecture it is
running on.

Continues the plumbing work in https://codereview.chromium.org/1698523003/ ,
toward the goal of enabling sandboxed translator tests for x86-64, particularly
on the spec bots.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4077
==========

[Jim Stichnoth, 2016-02-16 06:42:27]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[John, 2016-02-16 12:03:10]

lgtm

https://codereview.chromium.org/1696123003/diff/40001/src/IceBrowserCompileSe...
File src/IceBrowserCompileServer.cpp (right):

https://codereview.chromium.org/1696123003/diff/40001/src/IceBrowserCompileSe...
src/IceBrowserCompileServer.cpp:129: switch (__builtin_nacl_target_arch()) {
apparently __builtin_nacl_target_arch is deprecated, and __nacl_get_arch()
should be used instead.

[Jim Stichnoth, 2016-02-16 13:47:36]

Description was changed from

==========
Subzero: Set the correct target arch in the browser hookup.

The original implementation hard-coded the target to x86-32.

The new implementation mirrors pnacl-llc by probing the architecture it is
running on.

Continues the plumbing work in https://codereview.chromium.org/1698523003/ ,
toward the goal of enabling sandboxed translator tests for x86-64, particularly
on the spec bots.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4077
==========

to

==========
Subzero: Set the correct target arch in the browser hookup.

The original implementation hard-coded the target to x86-32.

The new implementation mirrors pnacl-llc by probing the architecture it is
running on.

Continues the plumbing work in https://codereview.chromium.org/1698523003/ ,
toward the goal of enabling sandboxed translator tests for x86-64, particularly
on the spec bots.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4077
R=jpp@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-02-16 13:47:38]

Committed patchset #3 (id:40001) manually as
816fd68fef0608236fc3fe0c2ce313c14487e3a6 (presubmit successful).

[Jim Stichnoth, 2016-02-16 13:52:12]

https://codereview.chromium.org/1696123003/diff/40001/src/IceBrowserCompileSe...
File src/IceBrowserCompileServer.cpp (right):

https://codereview.chromium.org/1696123003/diff/40001/src/IceBrowserCompileSe...
src/IceBrowserCompileServer.cpp:129: switch (__builtin_nacl_target_arch()) {
On 2016/02/16 12:03:10, John wrote:
> apparently __builtin_nacl_target_arch is deprecated, and __nacl_get_arch()
> should be used instead.

Yeah, I noticed that, but I have no idea why the trivial change wasn't already
made to pnacl-llc, so I kept it the same here to keep the similarity intact.