src/debug/mips64/debug-mips64.cc - Issue 1696043002: [runtime] Unify and simplify how frames are marked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/mips64/debug-mips64.cc

Issue 1696043002: [runtime] Unify and simplify how frames are marked (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix merge problems Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/mips64/debug-mips64.cc

diff --git a/src/debug/mips64/debug-mips64.cc b/src/debug/mips64/debug-mips64.cc

index 0646a249f7a92e2a512c91fd87cb7c800b4f092e..1288d43b008b02d10a5921150c63c338f3258796 100644

--- a/src/debug/mips64/debug-mips64.cc

+++ b/src/debug/mips64/debug-mips64.cc

@@ -116,9 +116,10 @@ void DebugCodegen::GenerateDebugBreakStub(MacroAssembler* masm,

void DebugCodegen::GenerateFrameDropperLiveEdit(MacroAssembler* masm) {

// We do not know our frame height, but set sp based on fp.

- __ Dsubu(sp, fp, Operand(kPointerSize));

+ __ ld(a1, MemOperand(fp, FrameDropperFrameConstants::kFunctionOffset));

- __ Pop(ra, fp, a1); // Return address, Frame, Function.

+ // Pop return address and frame.

+ __ LeaveFrame(StackFrame::INTERNAL);

ParameterCount dummy(0);

__ FloodFunctionIfStepping(a1, no_reg, dummy, dummy);