src/mips/codegen-mips.cc - Issue 1696043002: [runtime] Unify and simplify how frames are marked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/codegen-mips.cc

Issue 1696043002: [runtime] Unify and simplify how frames are marked (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: All platforms Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/codegen-mips.cc

diff --git a/src/mips/codegen-mips.cc b/src/mips/codegen-mips.cc

index 878ba3489a5d8be89221e605362a728ec581429c..1c6c1692ae0426f74a31d2c8d0ee7d3ebacb09e7 100644

--- a/src/mips/codegen-mips.cc

+++ b/src/mips/codegen-mips.cc

@@ -1197,10 +1197,8 @@ CodeAgingHelper::CodeAgingHelper(Isolate* isolate) {

young_sequence_.length() / Assembler::kInstrSize,

CodePatcher::DONT_FLUSH));

PredictableCodeSizeScope scope(patcher->masm(), young_sequence_.length());

- patcher->masm()->Push(ra, fp, cp, a1);

+ patcher->masm()->PushStandardFrame(a1);

patcher->masm()->nop(Assembler::CODE_AGE_SEQUENCE_NOP);

- patcher->masm()->Addu(

- fp, sp, Operand(StandardFrameConstants::kFixedFrameSizeFromFp));

}