src/debug/arm/debug-arm.cc - Issue 1696043002: [runtime] Unify and simplify how frames are marked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/arm/debug-arm.cc

Issue 1696043002: [runtime] Unify and simplify how frames are marked (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: All platforms Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/arm/debug-arm.cc

diff --git a/src/debug/arm/debug-arm.cc b/src/debug/arm/debug-arm.cc

index 5fdda4fedc34144011441d4165f8db5372f78489..99a555de9c5800e4deeb7d7d80db2a7025d40d7a 100644

--- a/src/debug/arm/debug-arm.cc

+++ b/src/debug/arm/debug-arm.cc

@@ -119,8 +119,7 @@ void DebugCodegen::GenerateDebugBreakStub(MacroAssembler* masm,

void DebugCodegen::GenerateFrameDropperLiveEdit(MacroAssembler* masm) {

// Load the function pointer off of our current stack frame.

- __ ldr(r1, MemOperand(fp,

- StandardFrameConstants::kConstantPoolOffset - kPointerSize));

+ __ ldr(r1, MemOperand(fp, FrameDropperFrameConstants::kFunctionOffset));

// Pop return address, frame and constant pool pointer (if

// FLAG_enable_embedded_constant_pool).