src/debug/ia32/debug-ia32.cc - Issue 1696043002: [runtime] Unify and simplify how frames are marked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/ia32/debug-ia32.cc

Issue 1696043002: [runtime] Unify and simplify how frames are marked (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Tweaks Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/ia32/debug-ia32.cc

diff --git a/src/debug/ia32/debug-ia32.cc b/src/debug/ia32/debug-ia32.cc

index 95f2bc6b68b5baccf89ad0b11e9ce805c1719c3e..5c7ea17e82dc1dc7b3607855b6422469bfd0be3c 100644

--- a/src/debug/ia32/debug-ia32.cc

+++ b/src/debug/ia32/debug-ia32.cc

@@ -110,9 +110,9 @@ void DebugCodegen::GenerateDebugBreakStub(MacroAssembler* masm,

void DebugCodegen::GenerateFrameDropperLiveEdit(MacroAssembler* masm) {

// We do not know our frame height, but set esp based on ebp.

- __ lea(esp, Operand(ebp, -1 * kPointerSize));

+ __ lea(esp, Operand(ebp, -3 * kPointerSize));

__ pop(edi); // Function.

+ __ add(esp, Immediate(kPointerSize * 2)); // INTERNAL frame marker and code

__ pop(ebp);

ParameterCount dummy(0);