Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: src/mips64/codegen-mips64.cc

Issue 1696043002: [runtime] Unify and simplify how frames are marked (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix merge problems Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/mips64/codegen-mips64.h" 5 #include "src/mips64/codegen-mips64.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/macro-assembler.h" 10 #include "src/macro-assembler.h"
(...skipping 1176 matching lines...) Expand 10 before | Expand all | Expand 10 after
1187 DCHECK(young_sequence_.length() == kNoCodeAgeSequenceLength); 1187 DCHECK(young_sequence_.length() == kNoCodeAgeSequenceLength);
1188 // Since patcher is a large object, allocate it dynamically when needed, 1188 // Since patcher is a large object, allocate it dynamically when needed,
1189 // to avoid overloading the stack in stress conditions. 1189 // to avoid overloading the stack in stress conditions.
1190 // DONT_FLUSH is used because the CodeAgingHelper is initialized early in 1190 // DONT_FLUSH is used because the CodeAgingHelper is initialized early in
1191 // the process, before MIPS simulator ICache is setup. 1191 // the process, before MIPS simulator ICache is setup.
1192 base::SmartPointer<CodePatcher> patcher( 1192 base::SmartPointer<CodePatcher> patcher(
1193 new CodePatcher(isolate, young_sequence_.start(), 1193 new CodePatcher(isolate, young_sequence_.start(),
1194 young_sequence_.length() / Assembler::kInstrSize, 1194 young_sequence_.length() / Assembler::kInstrSize,
1195 CodePatcher::DONT_FLUSH)); 1195 CodePatcher::DONT_FLUSH));
1196 PredictableCodeSizeScope scope(patcher->masm(), young_sequence_.length()); 1196 PredictableCodeSizeScope scope(patcher->masm(), young_sequence_.length());
1197 patcher->masm()->Push(ra, fp, cp, a1); 1197 patcher->masm()->PushStandardFrame(a1);
1198 patcher->masm()->nop(Assembler::CODE_AGE_SEQUENCE_NOP); 1198 patcher->masm()->nop(Assembler::CODE_AGE_SEQUENCE_NOP);
1199 patcher->masm()->nop(Assembler::CODE_AGE_SEQUENCE_NOP); 1199 patcher->masm()->nop(Assembler::CODE_AGE_SEQUENCE_NOP);
1200 patcher->masm()->nop(Assembler::CODE_AGE_SEQUENCE_NOP); 1200 patcher->masm()->nop(Assembler::CODE_AGE_SEQUENCE_NOP);
1201 patcher->masm()->Daddu(
1202 fp, sp, Operand(StandardFrameConstants::kFixedFrameSizeFromFp));
1203 } 1201 }
1204 1202
1205 1203
1206 #ifdef DEBUG 1204 #ifdef DEBUG
1207 bool CodeAgingHelper::IsOld(byte* candidate) const { 1205 bool CodeAgingHelper::IsOld(byte* candidate) const {
1208 return Memory::uint32_at(candidate) == kCodeAgePatchFirstInstruction; 1206 return Memory::uint32_at(candidate) == kCodeAgePatchFirstInstruction;
1209 } 1207 }
1210 #endif 1208 #endif
1211 1209
1212 1210
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
1258 } 1256 }
1259 } 1257 }
1260 1258
1261 1259
1262 #undef __ 1260 #undef __
1263 1261
1264 } // namespace internal 1262 } // namespace internal
1265 } // namespace v8 1263 } // namespace v8
1266 1264
1267 #endif // V8_TARGET_ARCH_MIPS64 1265 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698