Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 1696043002: [runtime] Unify and simplify how frames are marked (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix merge problems Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/arm/codegen-arm.h" 5 #include "src/arm/codegen-arm.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/arm/simulator-arm.h" 9 #include "src/arm/simulator-arm.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 880 matching lines...) Expand 10 before | Expand all | Expand 10 after
891 DCHECK(young_sequence_.length() == kNoCodeAgeSequenceLength); 891 DCHECK(young_sequence_.length() == kNoCodeAgeSequenceLength);
892 // Since patcher is a large object, allocate it dynamically when needed, 892 // Since patcher is a large object, allocate it dynamically when needed,
893 // to avoid overloading the stack in stress conditions. 893 // to avoid overloading the stack in stress conditions.
894 // DONT_FLUSH is used because the CodeAgingHelper is initialized early in 894 // DONT_FLUSH is used because the CodeAgingHelper is initialized early in
895 // the process, before ARM simulator ICache is setup. 895 // the process, before ARM simulator ICache is setup.
896 base::SmartPointer<CodePatcher> patcher( 896 base::SmartPointer<CodePatcher> patcher(
897 new CodePatcher(isolate, young_sequence_.start(), 897 new CodePatcher(isolate, young_sequence_.start(),
898 young_sequence_.length() / Assembler::kInstrSize, 898 young_sequence_.length() / Assembler::kInstrSize,
899 CodePatcher::DONT_FLUSH)); 899 CodePatcher::DONT_FLUSH));
900 PredictableCodeSizeScope scope(patcher->masm(), young_sequence_.length()); 900 PredictableCodeSizeScope scope(patcher->masm(), young_sequence_.length());
901 patcher->masm()->PushFixedFrame(r1); 901 patcher->masm()->PushStandardFrame(r1);
902 patcher->masm()->nop(ip.code()); 902 patcher->masm()->nop(ip.code());
903 patcher->masm()->add(
904 fp, sp, Operand(StandardFrameConstants::kFixedFrameSizeFromFp));
905 } 903 }
906 904
907 905
908 #ifdef DEBUG 906 #ifdef DEBUG
909 bool CodeAgingHelper::IsOld(byte* candidate) const { 907 bool CodeAgingHelper::IsOld(byte* candidate) const {
910 return Memory::uint32_at(candidate) == kCodeAgePatchFirstInstruction; 908 return Memory::uint32_at(candidate) == kCodeAgePatchFirstInstruction;
911 } 909 }
912 #endif 910 #endif
913 911
914 912
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
949 patcher.masm()->ldr(pc, MemOperand(pc, -4)); 947 patcher.masm()->ldr(pc, MemOperand(pc, -4));
950 patcher.masm()->emit_code_stub_address(stub); 948 patcher.masm()->emit_code_stub_address(stub);
951 } 949 }
952 } 950 }
953 951
954 952
955 } // namespace internal 953 } // namespace internal
956 } // namespace v8 954 } // namespace v8
957 955
958 #endif // V8_TARGET_ARCH_ARM 956 #endif // V8_TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698