Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Side by Side Diff: src/debug/liveedit.h

Issue 1696043002: [runtime] Unify and simplify how frames are marked (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Tweaks Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_DEBUG_LIVEEDIT_H_ 5 #ifndef V8_DEBUG_LIVEEDIT_H_
6 #define V8_DEBUG_LIVEEDIT_H_ 6 #define V8_DEBUG_LIVEEDIT_H_
7 7
8 8
9 // Live Edit feature implementation. 9 // Live Edit feature implementation.
10 // User should be able to change script on already running VM. This feature 10 // User should be able to change script on already running VM. This feature
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 * - padding size: a Smi storing n -- current size of padding 163 * - padding size: a Smi storing n -- current size of padding
164 * - padding: n words filled with kPaddingValue in form of Smi 164 * - padding: n words filled with kPaddingValue in form of Smi
165 * - 3 context/type words of a regular InternalFrame 165 * - 3 context/type words of a regular InternalFrame
166 * - fp 166 * - fp
167 * --- 167 * ---
168 * Topmost JavaScript frame 168 * Topmost JavaScript frame
169 * --- 169 * ---
170 * ... 170 * ...
171 * --- Bottom 171 * --- Bottom
172 */ 172 */
173 // A size of frame base including fp. Padding words starts right above
174 // the base.
175 static const int kFrameDropperFrameSize =
176 4 + StandardFrameConstants::kCPSlotCount;
177 // A number of words that should be reserved on stack for the LiveEdit use. 173 // A number of words that should be reserved on stack for the LiveEdit use.
178 // Stored on stack in form of Smi. 174 // Stored on stack in form of Smi.
179 static const int kFramePaddingInitialSize = 1; 175 static const int kFramePaddingInitialSize = 1;
180 // A value that padding words are filled with (in form of Smi). Going 176 // A value that padding words are filled with (in form of Smi). Going
181 // bottom-top, the first word not having this value is a counter word. 177 // bottom-top, the first word not having this value is a counter word.
182 static const int kFramePaddingValue = kFramePaddingInitialSize + 1; 178 static const int kFramePaddingValue = kFramePaddingInitialSize + 1;
183 }; 179 };
184 180
185 181
186 // A general-purpose comparator between 2 arrays. 182 // A general-purpose comparator between 2 arrays.
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 static const int kSharedInfoOffset_ = 3; 358 static const int kSharedInfoOffset_ = 3;
363 static const int kSize_ = 4; 359 static const int kSize_ = 4;
364 360
365 friend class JSArrayBasedStruct<SharedInfoWrapper>; 361 friend class JSArrayBasedStruct<SharedInfoWrapper>;
366 }; 362 };
367 363
368 } // namespace internal 364 } // namespace internal
369 } // namespace v8 365 } // namespace v8
370 366
371 #endif /* V8_DEBUG_LIVEEDIT_H_ */ 367 #endif /* V8_DEBUG_LIVEEDIT_H_ */
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698