Source/core/css/CSSProperty.cpp - Issue 16959008: [CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSProperty.cpp

Issue 16959008: [CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added a missing fix for a test in webexposed/ Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt ('K') | « Source/core/css/CSSParser.cpp ('k') | Source/core/css/CSSPropertyNames.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSProperty.cpp

diff --git a/Source/core/css/CSSProperty.cpp b/Source/core/css/CSSProperty.cpp

index d5cca5e84908e2bee8379414618b61c4a1a4cc9b..53263f8d57d3f2494267db40c1ab670c2ff24ff9 100644

--- a/Source/core/css/CSSProperty.cpp

+++ b/Source/core/css/CSSProperty.cpp

@@ -580,10 +580,10 @@ bool CSSProperty::isInheritedProperty(CSSPropertyID propertyID)

case CSSPropertyGridAutoRows:

case CSSPropertyGridBefore:

case CSSPropertyGridColumn:

- case CSSPropertyGridColumns:

+ case CSSPropertyGridDefinitionColumns:

case CSSPropertyGridEnd:

case CSSPropertyGridRow:

- case CSSPropertyGridRows:

+ case CSSPropertyGridDefinitionRows:

Julien - ping for review 2013/06/19 22:28:25 Let's keep this list ordered :)

svillar 2013/06/20 07:17:56 Oh sure.

case CSSPropertyGridStart:

case CSSPropertyGridArea:

case CSSPropertyWebkitJustifyContent: