LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint.html - Issue 16959008: [CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint.html

Issue 16959008: [CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added a missing fix for a test in webexposed/ Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-element-border-padding-grid-item.html ('k') | LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt » ('j') | LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint.html

diff --git a/LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint.html b/LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint.html

index ab2ea1e32c056a3dcd6d526dca2833779e0712f9..8bf14fd442fe611453781a39cd8362476f962a92 100644

--- a/LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint.html

+++ b/LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint.html

@@ -8,7 +8,7 @@ if (window.testRunner)

function repaintTest()

{

var gridElement = document.getElementsByClassName("grid")[0];

- gridElement.style.gridColumns = "minmax(50px, 180px) 100px 100px";

+ gridElement.style.gridDefinitionColumns = "minmax(50px, 180px) 100px 100px";

}

window.addEventListener("load", runRepaintTest, false);

</script>

@@ -20,15 +20,15 @@ body {

.grid {

width: -webkit-fit-content;

- grid-rows: 50px;

- grid-columns: minmax(100px, 180px) 100px minmax(50px, 100px);

+ grid-definition-rows: 50px;

+ grid-definition-columns: minmax(100px, 180px) 100px minmax(50px, 100px);

}

.sizedToGridArea {

background-color: purple;

}

</style>

<body>

-<div> This test checks that changing the grid-columns lead to a repaint. The final grid element should be 250px * 50px, the grid item should be 50px * 50px. No trace of the elements before the grid-columns change should be seen.</div>

+<div> This test checks that changing the grid-definition-columns lead to a repaint. The final grid element should be 250px * 50px, the grid item should be 50px * 50px. No trace of the elements before the grid-definition-columns change should be seen.</div>