LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout.html - Issue 16959008: [CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout.html

Issue 16959008: [CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added a missing fix for a test in webexposed/ Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt ('k') | LayoutTests/fast/css-grid-layout/grid-element-border-grid-item.html » ('j') | LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout.html

diff --git a/LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout.html b/LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout.html

index 6170b7a1582f7a3ea51ce5c89f00f2582e0cf62c..c1448de07630d6e57b7bba624cdb161b190a9be6 100644

--- a/LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout.html

+++ b/LayoutTests/fast/css-grid-layout/grid-dynamic-updates-relayout.html

@@ -10,8 +10,8 @@ if (window.testRunner)

function testLayout(gridElementID, gridTracks, size)

{

var gridElement = document.getElementById(gridElementID);

- gridElement.style.gridColumns = gridTracks.columns;

- gridElement.style.gridRows = gridTracks.rows;

+ gridElement.style.gridDefinitionColumns = gridTracks.columns;

+ gridElement.style.gridDefinitionRows = gridTracks.rows;

var gridItem = gridElement.firstChild.nextSibling;

gridItem.setAttribute("data-expected-width", size.width);

gridItem.setAttribute("data-expected-height", size.height);