Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 16959006: Refactor WebRTC master configs. (Closed)

Created:
7 years, 6 months ago by kjellander_chromium
Modified:
7 years, 6 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org, xusydoc+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Refactor WebRTC master configs. This change the WebRTC builder configurations to be more like the other waterfalls. The Subversion URL, branch and custom deps variables were used in the past for configuring builders for different branches and other customizations. TEST=presubmit BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=208455

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed minor errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -277 lines) Patch
M masters/master.client.webrtc/master.cfg View 1 chunk +3 lines, -5 lines 0 comments Download
M masters/master.client.webrtc/master_linux_cfg.py View 1 chunk +108 lines, -109 lines 0 comments Download
M masters/master.client.webrtc/master_mac_cfg.py View 1 chunk +82 lines, -83 lines 0 comments Download
M masters/master.client.webrtc/master_win_cfg.py View 1 chunk +59 lines, -58 lines 0 comments Download
M masters/master.tryserver.webrtc/master.cfg View 1 1 chunk +6 lines, -8 lines 0 comments Download
M scripts/master/factory/webrtc_factory.py View 1 3 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kjellander_chromium
Some cleanup to improve readability. https://codereview.chromium.org/16959006/diff/1/masters/master.client.webrtc/master_linux_cfg.py File masters/master.client.webrtc/master_linux_cfg.py (right): https://codereview.chromium.org/16959006/diff/1/masters/master.client.webrtc/master_linux_cfg.py#newcode102 masters/master.client.webrtc/master_linux_cfg.py:102: # Android. Not sure ...
7 years, 6 months ago (2013-06-19 09:52:48 UTC) #1
Mike Stip (use stip instead)
lgtm
7 years, 6 months ago (2013-06-21 19:50:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/16959006/2001
7 years, 6 months ago (2013-06-25 08:49:18 UTC) #3
commit-bot: I haz the power
7 years, 6 months ago (2013-06-25 08:50:05 UTC) #4
Message was sent while issue was closed.
Change committed as 208455

Powered by Google App Engine
This is Rietveld 408576698