Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: ppapi/api/dev/ppb_udp_socket_dev.idl

Issue 16959005: Implement PPB_UDPSocket_Dev: part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: In response to Cris's suggestions: not using base::ListValue; check conversoin in NetErrorToPepperE… Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/api/dev/ppb_udp_socket_dev.idl
diff --git a/ppapi/api/dev/ppb_udp_socket_dev.idl b/ppapi/api/dev/ppb_udp_socket_dev.idl
index 32ad30a81b21cb64d2aac5a93aa604447ccca020..2dcdcf33eddc03c321c734e9db4d1fd1cd41f13e 100644
--- a/ppapi/api/dev/ppb_udp_socket_dev.idl
+++ b/ppapi/api/dev/ppb_udp_socket_dev.idl
@@ -18,14 +18,17 @@ label Chrome {
enum PP_UDPSocket_Option_Dev {
// Allows the socket to share the local address to which it will be bound with
// other processes. Value's type should be PP_VARTYPE_BOOL.
+ // It should be set before calling Bind().
bbudge 2013/06/18 14:54:37 s/It/This option/ Here and below...
yzshen1 2013/06/18 16:39:16 Done.
PP_UDPSOCKET_OPTION_ADDRESS_REUSE = 0,
// Allows sending and receiving packets to and from broadcast addresses.
// Value's type should be PP_VARTYPE_BOOL.
+ // It should be set before calling Bind().
PP_UDPSOCKET_OPTION_BROADCAST = 1,
// Specifies the total per-socket buffer space reserved for sends. Value's
// type should be PP_VARTYPE_INT32.
+ // It should be set after a successful Bind() call.
// Note: This is only treated as a hint for the browser to set the buffer
// size. Even if SetOption() reports that this option has been successfully
// set, the browser doesn't guarantee it will conform to it.
@@ -33,6 +36,7 @@ enum PP_UDPSocket_Option_Dev {
// Specifies the total per-socket buffer space reserved for receives. Value's
// type should be PP_VARTYPE_INT32.
+ // It should be set after a successful Bind() call.
// Note: This is only treated as a hint for the browser to set the buffer
// size. Even if SetOption() reports that this option has been successfully
// set, the browser doesn't guarantee it will conform to it.
@@ -93,7 +97,7 @@ interface PPB_UDPSocket_Dev {
void Close([in] PP_Resource udp_socket);
/**
- * Sets a socket option to |udp_socket|. Should be called before Bind().
+ * Sets a socket option to |udp_socket|.
bbudge 2013/06/18 14:54:37 s/to/on
yzshen1 2013/06/18 16:39:16 Done.
* See the PP_UDPSocket_Option_Dev description for option names, value types
* and allowed values.
* Returns PP_OK on success. Otherwise, returns PP_ERROR_BADRESOURCE (if bad

Powered by Google App Engine
This is Rietveld 408576698