Implement PPB_UDPSocket_Dev: part 2

ppapi/host/error_conversion.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/host/error_conversion.h"
 
+#include <limits>
+
+#include "base/logging.h"
 #include "net/base/net_errors.h"
 #include "ppapi/c/pp_errors.h"
 
 namespace ppapi {
 namespace host {
 
 int32_t NetErrorToPepperError(int net_error) {
-  if (net_error > 0)
+  if (net_error > 0) {
+    CHECK_LE(net_error, std::numeric_limits<int32_t>::max());

[bbudge, 2013/06/18 14:54:37]

Should we crash the browser process?
Why not use base/safe_numerics.h "checked_numeric_cast<int32_t>()"?

[yzshen1, 2013/06/18 16:39:16]

I think it should be fine, because having a positive |net_error| value (usually
that means bytes transferred) that can overflow int32_t is not supposed to
happen.
Done. Thanks!

     return static_cast<int32_t>(net_error);
+  }
 
   switch (net_error) {
     case net::OK:
       return PP_OK;
     case net::ERR_IO_PENDING:
       return PP_OK_COMPLETIONPENDING;
     case net::ERR_ABORTED:
       return PP_ERROR_ABORTED;
     case net::ERR_INVALID_ARGUMENT:
       return PP_ERROR_BADARGUMENT;
@@ skipping 39 matching lines @@
       return PP_ERROR_MESSAGE_TOO_BIG;
     case net::ERR_ADDRESS_IN_USE:
       return PP_ERROR_ADDRESS_IN_USE;
     default:
       return PP_ERROR_FAILED;
   }
 }
 
 }  // namespace host
 }  // namespace ppapi