Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1695893004: RPC Explorer (Closed)

Created:
4 years, 10 months ago by nodir
Modified:
4 years, 9 months ago
Reviewers:
dnj, estaab, Bons
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@rpcepxlorer-deps
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

RPC Explorer RPC Explorer is a static HTML page that can discover services exposed by the same host and make calls. It uses Polymer for structure and data binding, and Bootstrap for graphical design. Committed: https://github.com/luci/luci-go/commit/72988cfe39e9560729746c4760f68350f654746f

Patch Set 1 : #

Total comments: 73

Patch Set 2 : nits #

Patch Set 3 : refactoring and tests #

Total comments: 39

Patch Set 4 : HTML5 history API and nits #

Patch Set 5 : removed broken rpc-error.html symlink #

Total comments: 4

Patch Set 6 : 80 chars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5868 lines, -4 lines) Patch
M appengine/static/common/include.yaml View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M appengine/static/dispatch.yaml View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M server/static/bower.json View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A server/static/bower_components/html5-history-anchor/.bower.json View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A + server/static/bower_components/html5-history-anchor/LICENSE.md View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A server/static/bower_components/html5-history-anchor/README.md View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download
A server/static/bower_components/html5-history-anchor/bower.json View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
A server/static/bower_components/html5-history-anchor/html5-history-anchor.html View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
A server/static/bower_components/html5-history-anchor/html5-history-anchor.js View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A server/static/bower_components/html5-history-anchor/html5-history-anchor.csp.html View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A server/static/bower_components/html5-history-anchor/src/html5-history-anchor.html View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A server/static/bower_components/html5-history-anchor/src/html5-history-anchor.js View 1 2 3 1 chunk +96 lines, -0 lines 0 comments Download
A server/static/rpc/rpc-call.html View 1 2 3 1 chunk +235 lines, -0 lines 0 comments Download
A server/static/rpc/rpc-client.html View 1 2 1 chunk +224 lines, -0 lines 0 comments Download
A server/static/rpc/rpc-code.html View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
A server/static/rpc/rpc-error.html View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A server/static/rpc/test/rpc-client.html View 1 2 1 chunk +256 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/README.md View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/index.html View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/rpc-completer.html View 1 2 3 4 5 1 chunk +305 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/rpc-descriptor-util.html View 1 2 3 1 chunk +205 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/rpc-editor.html View 1 2 3 1 chunk +103 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/rpc-explorer.html View 1 2 3 1 chunk +149 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/rpc-method.html View 1 2 3 1 chunk +206 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/rpc-service.html View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/rpc-service-list.html View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/test/descriptor.html View 1 2 3 1 chunk +3399 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/test/rpc-completer.html View 1 2 3 1 chunk +161 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/test/rpc-descriptor-util.html View 1 2 1 chunk +83 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/third_party/ace/README.md View 1 chunk +12 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/third_party/ace/ace.js View 1 chunk +11 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/third_party/ace/ext-language_tools.js View 1 chunk +5 lines, -0 lines 0 comments Download
A server/static/rpcexplorer/third_party/ace/mode-json.js View 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/bower_components/html5-history-anchor/html5-history-anchor.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpc/rpc-call.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpc/rpc-client.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpc/rpc-code.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpc/rpc-error.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpcexplorer/index.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpcexplorer/rpc-completer.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpcexplorer/rpc-descriptor-util.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpcexplorer/rpc-editor.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpcexplorer/rpc-explorer.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpcexplorer/rpc-method.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpcexplorer/rpc-service.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpcexplorer/rpc-service-list.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A server/static/upload/rpcexplorer/third_party View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 34 (17 generated)
nodir
Deployed here, with extra logdog descriptors: https://546-ea240d0-tainted-nodir-dot-luci-helloworld.appspot.com/rpcexplorer/ For autocompletion testing/demo, the following service methods have ...
4 years, 10 months ago (2016-02-13 12:49:45 UTC) #5
Bons
You have a BUG= line in the change description that you should remove unless it ...
4 years, 10 months ago (2016-02-13 17:18:29 UTC) #6
Bons
Also, where are the tests?
4 years, 10 months ago (2016-02-13 17:19:54 UTC) #7
nodir
PTAL. Addressed nits, wrote some jsdoc. Will add tests tomorrow. https://codereview.chromium.org/1695893004/diff/40001/server/static/rpcexplorer/index.html File server/static/rpcexplorer/index.html (right): https://codereview.chromium.org/1695893004/diff/40001/server/static/rpcexplorer/index.html#newcode2 ...
4 years, 10 months ago (2016-02-17 02:02:13 UTC) #10
nodir
Redeployed https://546-ea240d0-tainted-nodir-dot-luci-helloworld.appspot.com/rpcexplorer/
4 years, 10 months ago (2016-02-17 02:07:42 UTC) #11
Bons
Will take another look once tests are added. https://codereview.chromium.org/1695893004/diff/40001/server/static/rpcexplorer/rpc-call.html File server/static/rpcexplorer/rpc-call.html (right): https://codereview.chromium.org/1695893004/diff/40001/server/static/rpcexplorer/rpc-call.html#newcode44 server/static/rpcexplorer/rpc-call.html:44: * ...
4 years, 10 months ago (2016-02-17 19:27:47 UTC) #12
nodir
Split rpc-call element to rpc-client and rpc-call, to encapsulate iron-request. rpc-call's send() used to return ...
4 years, 10 months ago (2016-02-23 01:14:39 UTC) #17
nodir
On 2016/02/23 01:14:39, nodir wrote: > Split rpc-call element to rpc-client and rpc-call, to encapsulate ...
4 years, 10 months ago (2016-02-23 01:31:31 UTC) #18
Bons
https://codereview.chromium.org/1695893004/diff/170001/appengine/static/dispatch.yaml File appengine/static/dispatch.yaml (right): https://codereview.chromium.org/1695893004/diff/170001/appengine/static/dispatch.yaml#newcode1 appengine/static/dispatch.yaml:1: # This is a boilerplate dispatch.yaml that will work ...
4 years, 10 months ago (2016-02-23 15:52:29 UTC) #19
nodir
https://codereview.chromium.org/1695893004/diff/170001/appengine/static/dispatch.yaml File appengine/static/dispatch.yaml (right): https://codereview.chromium.org/1695893004/diff/170001/appengine/static/dispatch.yaml#newcode1 appengine/static/dispatch.yaml:1: # This is a boilerplate dispatch.yaml that will work ...
4 years, 10 months ago (2016-02-23 18:32:26 UTC) #21
nodir
https://codereview.chromium.org/1695893004/diff/170001/appengine/static/common/include.yaml File appengine/static/common/include.yaml (right): https://codereview.chromium.org/1695893004/diff/170001/appengine/static/common/include.yaml#newcode10 appengine/static/common/include.yaml:10: upload: common/upload/rpcexplorer/.+ I don't actually need this because all ...
4 years, 10 months ago (2016-02-23 18:34:18 UTC) #22
nodir
Redeployed https://rpcexplorer-dot-luci-helloworld.appspot.com/rpcexplorer/ with the HTML5 history change
4 years, 10 months ago (2016-02-23 20:51:48 UTC) #23
Bons
lgtm https://codereview.chromium.org/1695893004/diff/170001/server/static/rpcexplorer/rpc-explorer.html File server/static/rpcexplorer/rpc-explorer.html (right): https://codereview.chromium.org/1695893004/diff/170001/server/static/rpcexplorer/rpc-explorer.html#newcode22 server/static/rpcexplorer/rpc-explorer.html:22: li[hidden] { On 2016/02/23 18:32:25, nodir wrote: > ...
4 years, 10 months ago (2016-02-24 06:10:56 UTC) #24
nodir
https://codereview.chromium.org/1695893004/diff/230001/server/static/bower_components/html5-history-anchor/LICENSE.md File server/static/bower_components/html5-history-anchor/LICENSE.md (right): https://codereview.chromium.org/1695893004/diff/230001/server/static/bower_components/html5-history-anchor/LICENSE.md#newcode3 server/static/bower_components/html5-history-anchor/LICENSE.md:3: Copyright (c) 2014 Erik Ringsmuth On 2016/02/24 06:10:56, Bons ...
4 years, 10 months ago (2016-02-24 18:06:15 UTC) #25
commit-bot: I haz the power
This CL has an open dependency (Issue 1695933002 Patch 70001). Please resolve the dependency and ...
4 years, 10 months ago (2016-02-24 18:06:34 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695893004/250001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695893004/250001
4 years, 9 months ago (2016-02-29 18:24:05 UTC) #32
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 18:27:51 UTC) #34
Message was sent while issue was closed. 
Committed patchset #6 (id:250001) as
https://github.com/luci/luci-go/commit/72988cfe39e9560729746c4760f68350f654746f

Powered by Google App Engine
This is Rietveld 408576698