Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: tools/lexer_generator/dfa.py

Issue 169583003: Experimental parser: more verification (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/parser
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/lexer_generator/dfa_minimizer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/lexer_generator/dfa.py
diff --git a/tools/lexer_generator/dfa.py b/tools/lexer_generator/dfa.py
index be59ac0c27020bf4647e282e6608372d88a2a9a1..9631546e925802ce97d55cbc7cf4d9d03d41aa29 100644
--- a/tools/lexer_generator/dfa.py
+++ b/tools/lexer_generator/dfa.py
@@ -89,6 +89,7 @@ class Dfa(Automaton):
name_map[name] = (node, transitions)
if node_data['terminal']:
self.__terminal_set.add(node)
+ all_keys = []
for name, node_data in mapping.items():
(node, transitions) = name_map[name]
inversion = {}
@@ -97,16 +98,32 @@ class Dfa(Automaton):
inversion[state] = []
inversion[state].append(key)
for state, keys in inversion.items():
+ all_keys += keys
merged_key = TransitionKey.merged_key(encoding, keys)
self.__add_transition(transitions, merged_key, name_map[state][0])
self.__start = name_map[start_name][0]
self.__node_count = len(mapping)
+ self.__disjoint_keys = sorted(
+ TransitionKey.disjoint_keys(encoding, all_keys))
self.__verify()
def __verify(self):
assert self.__terminal_set
state_count = self.visit_all_states(lambda state, count: count + 1, 0)
assert self.__node_count == state_count
+ # assert keys are disjoint
+ def f(state, remaining):
+ remaining = set(TransitionKey.disjoint_keys(self.encoding(),
+ state.key_iter()))
+ for key in state.key_iter():
+ to_drop = set(filter(lambda x : key.is_superset_of_key(x), remaining))
+ assert to_drop
+ remaining -= to_drop
+ assert not remaining
+ self.visit_all_states(f, set(self.disjoint_keys_iter()))
+
+ def disjoint_keys_iter(self):
+ return iter(self.__disjoint_keys)
def node_count(self):
return self.__node_count
« no previous file with comments | « no previous file | tools/lexer_generator/dfa_minimizer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698