Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1768)

Unified Diff: tools/testing/dart/browser_controller.dart

Issue 16958003: Moving timing info to utils.dart:DebugLogger (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/browser_controller.dart
diff --git a/tools/testing/dart/browser_controller.dart b/tools/testing/dart/browser_controller.dart
index b8b5692d1523f3774c2f2ff38bc1786fb877553d..d2255077ea14130b8c8f913e25b52f8a4102c575 100644
--- a/tools/testing/dart/browser_controller.dart
+++ b/tools/testing/dart/browser_controller.dart
@@ -72,7 +72,7 @@ abstract class Browser {
}
void _logEvent(String event) {
- String toLog = "$this ($id) - ${new DateTime.now()}: $event \n";
+ String toLog = "$this ($id) - $event \n";
if (debugPrint) print("usageLog: $toLog");
if (logger != null) logger(toLog);
_usageLog.write(toLog);
@@ -562,8 +562,7 @@ class BrowserTestRunner {
void handleResults(String browserId, String output, int testId) {
var status = browserStatus[browserId];
- DebugLogger.info("${new DateTime.now()}: Handling result for "
- "browser ${browserId}");
+ DebugLogger.info("Handling result for browser ${browserId}");
if (testCache.containsKey(testId)) {
doubleReportingTests.add(testId);
return;
@@ -602,8 +601,7 @@ class BrowserTestRunner {
void handleTimeout(BrowserTestingStatus status) {
// We simply kill the browser and starts up a new one!
// We could be smarter here, but it does not seems like it is worth it.
- DebugLogger.info("${new DateTime.now()}: Handling timeout for "
- "browser ${status.browser.id}");
+ DebugLogger.info("Handling timeout for browser ${status.browser.id}");
status.timeout = true;
timedOut.add(status.currentTest.url);
var id = status.browser.id;
@@ -657,7 +655,7 @@ class BrowserTestRunner {
if (testQueue.isEmpty) return null;
var status = browserStatus[browserId];
if (status == null) return null;
- DebugLogger.info("${new DateTime.now()}: Handling getNext for browser "
+ DebugLogger.info("Handling getNext for browser "
"${browserId} timeout status: ${status.timeout}");
// We are currently terminating this browser, don't start a new test.
« no previous file with comments | « no previous file | tools/testing/dart/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698