Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1695753003: Add a dependency from the debugger on tools.gyp:url_data_manager. (Closed)

Created:
4 years, 10 months ago by jbroman
Modified:
4 years, 10 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/debugger.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695753003/1
4 years, 10 months ago (2016-02-12 19:08:37 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 10 months ago (2016-02-12 19:08:37 UTC) #4
jbroman
Ran into this while trying to build the Skia debugger. Fix seems straightforward to me.
4 years, 10 months ago (2016-02-12 19:09:21 UTC) #6
bsalomon
lgtm
4 years, 10 months ago (2016-02-12 19:09:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695753003/1
4 years, 10 months ago (2016-02-12 19:13:01 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 19:29:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bbfe47bd0fd328a387722e233304f35f4f9d27a2

Powered by Google App Engine
This is Rietveld 408576698