test/mjsunit/samevalue.js - Issue 1695743003: [builtins] Support SameValue and SameValueZero via runtime functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mjsunit/samevalue.js

Issue 1695743003: [builtins] Support SameValue and SameValueZero via runtime functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mjsunit/samevalue.js

diff --git a/test/mjsunit/samevalue.js b/test/mjsunit/samevalue.js

index 038fd68eb9c09673c9d56174be2d3460bac259d9..40d0a4b1f18f2929374f33e6622e6a6be7df9f0d 100644

--- a/test/mjsunit/samevalue.js

+++ b/test/mjsunit/samevalue.js

@@ -33,7 +33,7 @@ var obj1 = {x: 10, y: 11, z: "test"};

var obj2 = {x: 10, y: 11, z: "test"};

var sameValue = Object.is;

-var sameValueZero = natives.ImportNow("SameValueZero");

+var sameValueZero = function(x, y) { return %SameValue(x, y); }

Michael Starzinger 2016/02/17 09:44:21 Shouldn't this be %SameValueZero here?

Benedikt Meurer 2016/02/17 10:20:26 Done.

// Calls SameValue and SameValueZero and checks that their results match.

function sameValueBoth(a, b) {

« src/js/v8natives.js ('K') | « test/mjsunit/harmony/simd.js ('k') | no next file » | no next file with comments »