Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1695723002: Revert of [CT] Use zips of SKPs to speed up "isolate tests" in recipes (Closed)

Created:
4 years, 10 months ago by rmistry1
Modified:
4 years, 10 months ago
Reviewers:
borenet, rmistry
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of [CT] Use zips of SKPs to speed up "isolate tests" in recipes (patchset #3 id:40001 of https://codereview.chromium.org/1689093004/ ) Reason for revert: The zipping and unzipping process seems to take longer than the isolate binary did for >100k files. Reverting this experiment. I am instead going to break up the "isolate tests" steps into multiple steps if >100k files. Original issue's description: > [CT] Use zips of SKPs to speed up "isolate tests" in recipes. > > Context: The isolate binary is slow when it deals with >100k files (see https://github.com/luci/luci-go/issues/9) > This change compresses the 1M SKPs into 100 zip files. > > See related .isolate change in https://codereview.chromium.org/1691023002/ > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298749 TBR=borenet@google.com,rmistry@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -308 lines) Patch
M scripts/slave/recipes/skia/ct_skps.py View 3 chunks +2 lines, -8 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_BENCH_10k_SKPs.json View 5 chunks +0 lines, -50 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs.json View 5 chunks +0 lines, -50 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs_2slaves_failure.json View 5 chunks +0 lines, -50 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs_Trybot.json View 5 chunks +0 lines, -50 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs_slave3_failure.json View 5 chunks +0 lines, -50 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_1m_SKPs.json View 5 chunks +0 lines, -50 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmistry1
Created Revert of [CT] Use zips of SKPs to speed up "isolate tests" in recipes
4 years, 10 months ago (2016-02-12 12:03:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695723002/1
4 years, 10 months ago (2016-02-12 12:03:29 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 12:03:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298755

Powered by Google App Engine
This is Rietveld 408576698