Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 16957003: Allow allocations in spaces with constant allocation size use the (Closed)

Created:
7 years, 6 months ago by Hannes Payer (out of office)
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Allow allocations in spaces with constant allocation size use the smallest possible size-class. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15129

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M src/spaces.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/spaces.cc View 1 2 4 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
7 years, 6 months ago (2013-06-13 12:54:38 UTC) #1
Michael Starzinger
LGTM with one suggestion. https://codereview.chromium.org/16957003/diff/2001/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/16957003/diff/2001/src/spaces.cc#newcode2236 src/spaces.cc:2236: ASSERT(size_in_bytes <= *node_size); Can we ...
7 years, 6 months ago (2013-06-13 13:00:13 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/16957003/diff/2001/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/16957003/diff/2001/src/spaces.cc#newcode2236 src/spaces.cc:2236: ASSERT(size_in_bytes <= *node_size); On 2013/06/13 13:00:13, Michael Starzinger wrote: ...
7 years, 6 months ago (2013-06-13 17:03:37 UTC) #3
Hannes Payer (out of office)
7 years, 6 months ago (2013-06-13 17:04:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r15129 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698