Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1526)

Unified Diff: third_party/libaddressinput/BUILD.gn

Issue 1695663005: [Testing] Version 2: Run libaddressinput_unittests on bots Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Initial Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/buildbot/gn_isolate_map.pyl ('k') | third_party/libaddressinput/libaddressinput.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libaddressinput/BUILD.gn
diff --git a/third_party/libaddressinput/BUILD.gn b/third_party/libaddressinput/BUILD.gn
index 4132f149cc39b9f70e54e1edad4c912d6125e527..f8af1ec66102617379184da36744c7c875de72ac 100644
--- a/third_party/libaddressinput/BUILD.gn
+++ b/third_party/libaddressinput/BUILD.gn
@@ -186,34 +186,51 @@ if (!is_android || use_aura) {
]
}
- test("libaddressinput_unittests") {
- sources =
- rebase_path(gypi_values.libaddressinput_test_files, ".", "src/cpp")
- sources += [
- "chromium/addressinput_util_unittest.cc",
- "chromium/chrome_address_validator_unittest.cc",
- "chromium/chrome_metadata_source_unittest.cc",
- "chromium/chrome_storage_impl_unittest.cc",
- "chromium/fallback_data_store_unittest.cc",
- "chromium/storage_test_runner.cc",
- "chromium/string_compare_unittest.cc",
- "chromium/trie_unittest.cc",
- ]
-
- configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
-
- defines = [ "TEST_DATA_DIR=\"third_party/libaddressinput/src/testdata\"" ]
+ template("unittests") {
+ test(target_name) {
+ sources =
+ rebase_path(gypi_values.libaddressinput_test_files, ".", "src/cpp")
+ sources += [
+ "chromium/addressinput_util_unittest.cc",
+ "chromium/chrome_address_validator_unittest.cc",
+ "chromium/chrome_metadata_source_unittest.cc",
+ "chromium/chrome_storage_impl_unittest.cc",
+ "chromium/fallback_data_store_unittest.cc",
+ "chromium/storage_test_runner.cc",
+ "chromium/string_compare_unittest.cc",
+ "chromium/trie_unittest.cc",
+ ]
+ data = [
+ "src/testdata/",
+ ]
+
+ configs -= [ "//build/config/compiler:chromium_code" ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
+
+ defines = invoker.defines
+
+ include_dirs = [ "src/cpp/src" ]
+
+ deps = [
+ ":libaddressinput",
+ ":strings",
+ "//base/test:run_all_unittests",
+ "//components/prefs",
+ "//net:test_support",
+ "//testing/gtest",
+ ]
+ }
+ }
- include_dirs = [ "src/cpp/src" ]
+ # Can be used to run tests locally, from the checkout directory (not src).
+ unittests("libaddressinput_unittests_local") {
+ defines =
+ [ "TEST_DATA_DIR=\"src/third_party/libaddressinput/src/testdata\"" ]
+ }
- deps = [
- ":libaddressinput",
- ":strings",
- "//base/test:run_all_unittests",
- "//components/prefs",
- "//net:test_support",
- "//testing/gtest",
- ]
+ # Used only for swarming.
+ unittests("libaddressinput_unittests") {
+ defines = [ "TEST_DATA_DIR=\"" + rebase_path("../..", root_out_dir) +
+ "/third_party/libaddressinput/src/testdata\"" ]
}
}
« no previous file with comments | « testing/buildbot/gn_isolate_map.pyl ('k') | third_party/libaddressinput/libaddressinput.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698