Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1695633003: [runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix MIPS dead code Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-create-lowering.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/arm/full-codegen-arm.cc
diff --git a/src/full-codegen/arm/full-codegen-arm.cc b/src/full-codegen/arm/full-codegen-arm.cc
index e61bbfa9471d583e00a3ad3f6485ad2f119d636d..f03946d5703f636c907dc5887b2cdf2a9dfa4813 100644
--- a/src/full-codegen/arm/full-codegen-arm.cc
+++ b/src/full-codegen/arm/full-codegen-arm.cc
@@ -277,23 +277,11 @@ void FullCodeGenerator::Generate() {
if (is_strict(language_mode()) || !has_simple_parameters()) {
FastNewStrictArgumentsStub stub(isolate());
__ CallStub(&stub);
+ } else if (literal()->has_duplicate_parameters()) {
+ __ Push(r1);
+ __ CallRuntime(Runtime::kNewSloppyArguments_Generic);
} else {
- DCHECK(r1.is(ArgumentsAccessNewDescriptor::function()));
- // Receiver is just before the parameters on the caller's stack.
- int num_parameters = info->scope()->num_parameters();
- int offset = num_parameters * kPointerSize;
- __ mov(ArgumentsAccessNewDescriptor::parameter_count(),
- Operand(Smi::FromInt(num_parameters)));
- __ add(ArgumentsAccessNewDescriptor::parameter_pointer(), fp,
- Operand(StandardFrameConstants::kCallerSPOffset + offset));
-
- // Arguments to ArgumentsAccessStub:
- // function, parameter pointer, parameter count.
- // The stub will rewrite parameter pointer and parameter count if the
- // previous stack frame was an arguments adapter frame.
- ArgumentsAccessStub::Type type = ArgumentsAccessStub::ComputeType(
- literal()->has_duplicate_parameters());
- ArgumentsAccessStub stub(isolate(), type);
+ FastNewSloppyArgumentsStub stub(isolate());
__ CallStub(&stub);
}
« no previous file with comments | « src/compiler/js-create-lowering.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698