Issue 169563002: Added a special stack guard to deopt marked allocation sites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 169563002: Added a special stack guard to deopt marked allocation sites. (Closed)

Created:
6 years, 10 months ago by Hannes Payer (out of office)

Modified:
6 years, 10 months ago

Reviewers:
mvstanton, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Added a special stack guard to deopt marked allocation sites. BUG= R=mvstanton@chromium.org, ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19404

Patch Set 4 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -21 lines)			Patch
M	src/execution.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/execution.cc	View	1 2	2 chunks	+7 lines, -7 lines	0 comments	Download
M	src/heap.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	1 2 3	3 chunks	+25 lines, -6 lines	0 comments	Download
M	src/objects.h	View	1 2	2 chunks	+15 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mvstanton

LGTM. https://codereview.chromium.org/169563002/diff/50001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/169563002/diff/50001/src/heap.cc#newcode573 src/heap.cc:573: // TODO(hpayer): If iterating over the alloation sites ...

6 years, 10 months ago (2014-02-17 12:10:05 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/169563002/diff/50001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/169563002/diff/50001/src/heap.cc#newcode573 src/heap.cc:573: // TODO(hpayer): If iterating over the alloation sites list ...

6 years, 10 months ago (2014-02-17 12:14:43 UTC) #4

Hannes Payer (out of office)

6 years, 10 months ago (2014-02-17 12:15:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r19404 (presubmit successful).

Expand Messages | Collapse Messages

Issue 169563002: Added a special stack guard to deopt marked allocation sites. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages