Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 1695583002: Remove RTCVideoDecoder Reset method. (Closed)

Created:
4 years, 10 months ago by pbos
Modified:
4 years, 10 months ago
Reviewers:
perkj_chrome, mcasas
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RTCVideoDecoder Reset method. No longer called by WebRTC which simply waits until a keyframe becomes available instead of resetting the decoder inbetween. BUG=webrtc:5475 R=perkj@chromium.org Committed: https://crrev.com/17d064b149fdc41c18df13173b56dd27197d7286 Cr-Commit-Position: refs/heads/master@{#375158}

Patch Set 1 #

Patch Set 2 : remove ResetReturnOk test, still covered by ReleaseReturnsOk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -20 lines) Patch
M content/renderer/media/rtc_video_decoder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 5 chunks +4 lines, -9 lines 0 comments Download
M content/renderer/media/rtc_video_decoder_unittest.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
pbos
PTAL
4 years, 10 months ago (2016-02-11 23:14:08 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695583002/1
4 years, 10 months ago (2016-02-11 23:16:07 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
4 years, 10 months ago (2016-02-11 23:16:08 UTC) #5
pbos
On 2016/02/11 23:16:08, commit-bot: I haz the power wrote: > Dry run: No L-G-T-M from ...
4 years, 10 months ago (2016-02-11 23:17:18 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695583002/1
4 years, 10 months ago (2016-02-11 23:39:35 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/115085)
4 years, 10 months ago (2016-02-12 00:10:24 UTC) #10
pbos
remove ResetReturnOk test, still covered by ReleaseReturnsOk
4 years, 10 months ago (2016-02-12 06:26:11 UTC) #11
pbos
On 2016/02/12 00:10:24, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 10 months ago (2016-02-12 06:26:18 UTC) #12
perkj_chrome
lgtm
4 years, 10 months ago (2016-02-12 09:13:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695583002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695583002/20001
4 years, 10 months ago (2016-02-12 09:18:05 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-12 10:31:04 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:42:37 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/17d064b149fdc41c18df13173b56dd27197d7286
Cr-Commit-Position: refs/heads/master@{#375158}

Powered by Google App Engine
This is Rietveld 408576698