Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1695573002: Update the AudioParam value attribute correctly from timelines. (Closed)

Created:
4 years, 10 months ago by Raymond Toy
Modified:
4 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the AudioParam value attribute correctly from timelines. The automation functions exponentialRampToValueAtTime, setTargetAtTime, and setValueCurveAtTime were not correctly updating the .value attribute of the AudioParam. For the first two methods, the computed value was one frame too far into the future. For last method, the return value was always the last curve element, which is wrong. BUG=574905 TEST=audioparam-update-value-attribute.html Committed: https://crrev.com/4007885e576b357d43eb4bd78f03254267aa2a01 Cr-Commit-Position: refs/heads/master@{#376044}

Patch Set 1 : #

Patch Set 2 : Reduce printed precision of results (for windows) #

Patch Set 3 : Rebase and reduce printed precision some more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/webaudio/audioparam-update-value-attribute.html View 1 2 1 chunk +172 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/audioparam-update-value-attribute-expected.txt View 1 2 1 chunk +97 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/resources/audio-param.js View 1 chunk +46 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp View 7 chunks +28 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Raymond Toy
PTAL.
4 years, 10 months ago (2016-02-11 23:45:27 UTC) #2
hongchan
lgtm
4 years, 10 months ago (2016-02-16 23:13:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695573002/40001
4 years, 10 months ago (2016-02-16 23:46:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/174616)
4 years, 10 months ago (2016-02-17 03:50:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695573002/60001
4 years, 10 months ago (2016-02-17 21:08:54 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 10 months ago (2016-02-18 00:14:17 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 00:15:34 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4007885e576b357d43eb4bd78f03254267aa2a01
Cr-Commit-Position: refs/heads/master@{#376044}

Powered by Google App Engine
This is Rietveld 408576698