extensions/common/permissions/media_galleries_permission.cc - Issue 1695563002: Media Galleries Partial Deprecation: Remove scan functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/permissions/media_galleries_permission.cc

Issue 1695563002: Media Galleries Partial Deprecation: Remove scan functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/media_galleries_histograms.h ('K') | « extensions/browser/extension_function_histogram_value.h ('k') | extensions/common/permissions/media_galleries_permission_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/permissions/media_galleries_permission.cc

diff --git a/extensions/common/permissions/media_galleries_permission.cc b/extensions/common/permissions/media_galleries_permission.cc

index 6a432686a56e90806c34387f17130091c9b21d3a..4ac5ae6c0c94214e891d14e61bab8a5cd04a326b 100644

--- a/extensions/common/permissions/media_galleries_permission.cc

+++ b/extensions/common/permissions/media_galleries_permission.cc

@@ -96,7 +96,6 @@ void AddPermissionsToLists(

const char MediaGalleriesPermission::kAllAutoDetectedPermission[] =

"allAutoDetected";

-const char MediaGalleriesPermission::kScanPermission[] = "scan";

const char MediaGalleriesPermission::kReadPermission[] = "read";

const char MediaGalleriesPermission::kCopyToPermission[] = "copyTo";

const char MediaGalleriesPermission::kDeletePermission[] = "delete";

@@ -137,8 +136,7 @@ bool MediaGalleriesPermission::FromValue(

bool has_delete = false;

for (std::set<MediaGalleriesPermissionData>::const_iterator it =

data_set_.begin(); it != data_set_.end(); ++it) {

- if (it->permission() == kAllAutoDetectedPermission ||

- it->permission() == kScanPermission) {

+ if (it->permission() == kAllAutoDetectedPermission) {

continue;

}

if (it->permission() == kReadPermission) {