Media Galleries Partial Deprecation: Remove scan functionality.

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/common/pref_font_webkit_names.h"
 
@@ skipping 1950 matching lines @@
 const char kAttemptedToEnableAutoupdate[] =
     "browser.attempted_to_enable_autoupdate";
 
 // The next media gallery ID to assign.
 const char kMediaGalleriesUniqueId[] = "media_galleries.gallery_id";
 
 // A list of dictionaries, where each dictionary represents a known media
 // gallery.
 const char kMediaGalleriesRememberedGalleries[] =
     "media_galleries.remembered_galleries";
-
-// The last time a media scan completed.
-const char kMediaGalleriesLastScanTime[] = "media_galleries.last_scan_time";

[Devlin, 2016/02/29 20:37:24]

Do we need to clean this up in users' pref files?

[tommycli, 2016/02/29 21:53:30]

When I discussed this with thestig, we thought that it would be okay if this key
dangled around user profiles.

When the profile is saved, do you know if unknown keys are written to disk
again? Or discarded?

[Devlin, 2016/02/29 22:10:44]

Unknown keys are still written to disk last I checked (a few months back, so
maybe things have changed?).  I think this is somewhat by design - maybe we
didn't want to unintentially clear out everyone's prefs if we accidentally
unregistered one?

Easy enough to test locally. :)

[tommycli, 2016/02/29 22:49:03]

SGTM. I'm okay with leaving this dangling since the # of MG users who have ever
scanned is basically non-existent.

 #endif  // !defined(OS_ANDROID) && !defined(OS_IOS)
 
 #if defined(USE_ASH)
 // |kShelfAlignment| and |kShelfAutoHideBehavior| have a local variant. The
 // local variant is not synced and is used if set. If the local variant is not
 // set its value is set from the synced value (once prefs have been
 // synced). This gives a per-machine setting that is initialized from the last
 // set value.
 // These values are default on the machine but can be overridden by per-display
 // values in kShelfPreferences (unless overridden by managed policy).
@@ skipping 193 matching lines @@
 const char kMediaRouterEnableCloudServices[] =
     "media_router.cloudservices.enabled";
 #endif  // defined(GOOGLE_CHROME_BUILD)
 // Whether or not the Media Router first run flow has been acknowledged by the
 // user.
 const char kMediaRouterFirstRunFlowAcknowledged[] =
     "media_router.firstrunflow.acknowledged";
 #endif
 
 }  // namespace prefs