Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1695503002:
Expand base::Tuple to std::tuple in a class template specialization (Closed)
DescriptionExpand base::Tuple to std::tuple in a class template specialization
MSVC2015U1 seems to hit an internal compiler error for this.
BUG=554987, 440500, 586187
Committed: https://crrev.com/f49d891abad0752fabcb2a0dd962f814588cc4b0
Cr-Commit-Position: refs/heads/master@{#375021}
Patch Set 1 #
Messages
Total messages: 21 (10 generated)
Description was changed from ========== Expand base::Tuple to std::tuple in a class template specialization BUG= ========== to ========== Expand base::Tuple to std::tuple in a class template specialization MSVC2015U1 seems to hit an internal compiler error for this. BUG= ==========
tzik@chromium.org changed reviewers: + sebmarchand@chromium.org, thakis@chromium.org
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
PTAL
Description was changed from ========== Expand base::Tuple to std::tuple in a class template specialization MSVC2015U1 seems to hit an internal compiler error for this. BUG= ========== to ========== Expand base::Tuple to std::tuple in a class template specialization MSVC2015U1 seems to hit an internal compiler error for this. BUG=554987 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695503002/1
rs-lgtm
Description was changed from ========== Expand base::Tuple to std::tuple in a class template specialization MSVC2015U1 seems to hit an internal compiler error for this. BUG=554987 ========== to ========== Expand base::Tuple to std::tuple in a class template specialization MSVC2015U1 seems to hit an internal compiler error for this. BUG=554987, 440500 ==========
lgtm, have you tried to compile this with VS2015 or is it a tentative fix ? It might break at more places (see https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Builder/builds/...)
Description was changed from ========== Expand base::Tuple to std::tuple in a class template specialization MSVC2015U1 seems to hit an internal compiler error for this. BUG=554987, 440500 ========== to ========== Expand base::Tuple to std::tuple in a class template specialization MSVC2015U1 seems to hit an internal compiler error for this. BUG=554987, 440500, 586187 ==========
On 2016/02/11 18:59:25, Sébastien Marchand wrote: > lgtm, have you tried to compile this with VS2015 or is it a tentative fix ? It > might break at more places (see > https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Builder/builds/...) It's tentative. I'm compiling this locally now.
It seems to fix the problem on my machine (I've compiled all the compilands that fail on https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Builder/builds/... and they all compile successfully now). Thanks for the quick fix !
On 2016/02/11 19:16:19, Sébastien Marchand wrote: > It seems to fix the problem on my machine (I've compiled all the compilands that > fail on > https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Builder/builds/... > and they all compile successfully now). > > Thanks for the quick fix ! Finished to compile successfully on my machine. It's still linking, but compilation seems to finish anyway.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695503002/1
Message was sent while issue was closed.
Description was changed from ========== Expand base::Tuple to std::tuple in a class template specialization MSVC2015U1 seems to hit an internal compiler error for this. BUG=554987, 440500, 586187 ========== to ========== Expand base::Tuple to std::tuple in a class template specialization MSVC2015U1 seems to hit an internal compiler error for this. BUG=554987, 440500, 586187 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Expand base::Tuple to std::tuple in a class template specialization MSVC2015U1 seems to hit an internal compiler error for this. BUG=554987, 440500, 586187 ========== to ========== Expand base::Tuple to std::tuple in a class template specialization MSVC2015U1 seems to hit an internal compiler error for this. BUG=554987, 440500, 586187 Committed: https://crrev.com/f49d891abad0752fabcb2a0dd962f814588cc4b0 Cr-Commit-Position: refs/heads/master@{#375021} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f49d891abad0752fabcb2a0dd962f814588cc4b0 Cr-Commit-Position: refs/heads/master@{#375021} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
