Issue 16955005: Add MESA detection to GrContextInfo and use to decide whether to use GL_ALPHA or GL_RED.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16955005: Add MESA detection to GrContextInfo and use to decide whether to use GL_ALPHA or GL_RED. (Closed)

Created:
7 years, 6 months ago by bsalomon

Modified:
7 years, 6 months ago

Reviewers:
yunchao, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add MESA detection to GrContextInfo and use to decide whether to use GL_ALPHA or GL_RED. Based on yunchao.he@intel.com's original change here: https://codereview.chromium.org/15994006/ Committed: http://code.google.com/p/skia/source/detail?r=9608

Patch Set 2 : update CL comment #

Patch Set 3 : add comment, revert unneeded bool in GrGLCaps. #

Patch Set 4 : whitespace cleanup #

Total comments: 1

Patch Set 5 : fix comment type #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -3 lines)			Patch
M	src/gpu/gl/GrGLCaps.cpp	View	1 2 3	1 chunk	+8 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLContext.h	View	1 2 3 4	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLContext.cpp	View	1 2 3	3 chunks	+5 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLUtil.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLUtil.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 typo correction https://codereview.chromium.org/16955005/diff/6001/src/gpu/gl/GrGLContext.h File src/gpu/gl/GrGLContext.h (right): https://codereview.chromium.org/16955005/diff/6001/src/gpu/gl/GrGLContext.h#newcode49 src/gpu/gl/GrGLContext.h:49: GrGLVendor vendor() const { ...

7 years, 6 months ago (2013-06-13 13:33:04 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/16955005/11001

7 years, 6 months ago (2013-06-14 12:12:46 UTC) #4

Message was sent while issue was closed.

Change committed as 9608