Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1695493002: Have ASan ignore ObjectAliveTrait<>::isHeapObjectAlive() applied to mixins (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have ASan ignore ObjectAliveTrait<>::isHeapObjectAlive() applied to mixins When Heap::willObjectBeLazilySwept<T>() is used on a lazy-sweepable object where T is a mixin, the mixin's isHeapObjectAlive() virtual will have to be used to adjust the object pointer to the head of the object. It is unlikely that a compiler will devirtualize that call hence mark the isHeapObjectAlive() as ASan ignorable. R= BUG= Committed: https://crrev.com/4d46d2703674fc3377395ca699f6657b0a3192c3 Cr-Commit-Position: refs/heads/master@{#375137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 10 months ago (2016-02-11 18:45:22 UTC) #2
haraken
LGTM
4 years, 10 months ago (2016-02-11 23:48:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695493002/1
4 years, 10 months ago (2016-02-12 06:14:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 06:25:21 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:42:05 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d46d2703674fc3377395ca699f6657b0a3192c3
Cr-Commit-Position: refs/heads/master@{#375137}

Powered by Google App Engine
This is Rietveld 408576698