Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1695483002: [libphonenumber] move phonenumber_api.h up one level (Closed)

Created:
4 years, 10 months ago by Mathieu
Modified:
4 years, 10 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mkwst+moarreviews-renderer_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[libphonenumber] move phonenumber_api.h up one level In preparation for DEPS change coming. BUG=585286 TBR=tedchoc Committed: https://crrev.com/e587a17efeae4b26343ffce47c369e3a748f9468 Cr-Commit-Position: refs/heads/master@{#374955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M components/autofill/core/browser/phone_number_i18n.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/phone_number_i18n_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/android/phone_number_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libphonenumber/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/libphonenumber/phonenumber_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/libphonenumber/src/phonenumber_api.h View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Mathieu
Hi rouslan, please have a look. I have to do a multi-part change because of ...
4 years, 10 months ago (2016-02-11 18:35:06 UTC) #2
please use gerrit instead
lgtm
4 years, 10 months ago (2016-02-11 19:57:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695483002/1
4 years, 10 months ago (2016-02-11 19:58:36 UTC) #8
Mathieu
Thanks, TBR tedchoc because it's just an include change.
4 years, 10 months ago (2016-02-11 19:59:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695483002/1
4 years, 10 months ago (2016-02-11 20:01:09 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 20:07:25 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:37:08 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e587a17efeae4b26343ffce47c369e3a748f9468
Cr-Commit-Position: refs/heads/master@{#374955}

Powered by Google App Engine
This is Rietveld 408576698