src/codec/SkJpegCodec.cpp - Issue 1695473002: Fix colorType/alphaType checks in SkCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkJpegCodec.cpp

Issue 1695473002: Fix colorType/alphaType checks in SkCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Consistently require that kGray8 decodes be opaque Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkJpegCodec.cpp

diff --git a/src/codec/SkJpegCodec.cpp b/src/codec/SkJpegCodec.cpp

index aefe264f1ad9b1963e0359da4d51801b35b3d734..e6ac984b6576ece88613563ebc69baf2aabb77dc 100644

--- a/src/codec/SkJpegCodec.cpp

+++ b/src/codec/SkJpegCodec.cpp

@@ -354,6 +354,7 @@ void SkJpegCodec::initializeSwizzler(const SkImageInfo& dstInfo, const Options&

}

fSwizzler.reset(SkSwizzler::CreateSwizzler(srcConfig, nullptr, dstInfo, options));

+ SkASSERT(fSwizzler);

fStorage.reset(get_row_bytes(fDecoderMgr->dinfo()));

fSrcRow = fStorage.get();

}