src/codec/SkGifCodec.h - Issue 1695473002: Fix colorType/alphaType checks in SkCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkGifCodec.h

Issue 1695473002: Fix colorType/alphaType checks in SkCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Consistently require that kGray8 decodes be opaque Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkGifCodec.h

diff --git a/src/codec/SkGifCodec.h b/src/codec/SkGifCodec.h

index 91861b299abb8b884097eca33d476591378d72c6..010a344cf5c305f109dce64ded724d0169ea44e0 100644

--- a/src/codec/SkGifCodec.h

+++ b/src/codec/SkGifCodec.h

@@ -128,7 +128,7 @@ private:

* @param options Informs the swizzler if destination memory is zero initialized.

* Contains subset information.

- Result initializeSwizzler(const SkImageInfo& dstInfo,

+ void initializeSwizzler(const SkImageInfo& dstInfo,

const Options& options);

SkSampler* getSampler(bool createIfNecessary) override {