src/codec/SkBmpStandardCodec.h - Issue 1695473002: Fix colorType/alphaType checks in SkCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkBmpStandardCodec.h

Issue 1695473002: Fix colorType/alphaType checks in SkCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Consistently require that kGray8 decodes be opaque Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkBmpStandardCodec.h

diff --git a/src/codec/SkBmpStandardCodec.h b/src/codec/SkBmpStandardCodec.h

index b5f56f0a2aef048096c80fd3e4e906394abac09b..fafd0fbc3ed6a983350a6ac555bd8bfd07c08911 100644

--- a/src/codec/SkBmpStandardCodec.h

+++ b/src/codec/SkBmpStandardCodec.h

@@ -70,7 +70,7 @@ private:

bool createColorTable(SkAlphaType alphaType, int* colorCount);

- bool initializeSwizzler(const SkImageInfo& dstInfo, const Options& opts);

+ void initializeSwizzler(const SkImageInfo& dstInfo, const Options& opts);

int decodeRows(const SkImageInfo& dstInfo, void* dst, size_t dstRowBytes,

const Options& opts) override;