Fix colorType/alphaType checks in SkCodec

src/codec/SkWbmpCodec.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkCodec.h"
 #include "SkCodecPriv.h"
 #include "SkColorPriv.h"
@@ skipping 12 matching lines @@
 
 static inline void setup_color_table(SkColorType colorType,
         SkPMColor* colorPtr, int* colorCount) {
     if (kIndex_8_SkColorType == colorType) {
         colorPtr[0] = SK_ColorBLACK;
         colorPtr[1] = SK_ColorWHITE;
         *colorCount = 2;
     }
 }
 
+static inline bool valid_color_type(SkColorType colorType, SkAlphaType alphaType) {
+    switch (colorType) {
+        case kN32_SkColorType:
+        case kIndex_8_SkColorType:
+        case kGray_8_SkColorType:

[msarett, 2016/02/11 19:13:45]

Should kGray_8 also require that the alphaType is opaque?  If so, we should
change the version in SkCodecPriv.h as well.

[scroggo, 2016/02/12 17:13:55]

Not sure - this means that they have an inconsistent target...

+            return true;
+        case kRGB_565_SkColorType:
+            return kOpaque_SkAlphaType == alphaType;
+        default:
+            return false;
+    }
+}
+
 static bool read_byte(SkStream* stream, uint8_t* data)
 {
     return stream->read(data, 1) == 1;
 }
 
 // http://en.wikipedia.org/wiki/Variable-length_quantity
 static bool read_mbf(SkStream* stream, uint64_t* value) {
     uint64_t n = 0;
     uint8_t data;
     const uint64_t kLimit = 0xFE00000000000000;
@@ skipping 34 matching lines @@
     }
     return true;
 }
 
 bool SkWbmpCodec::onRewind() {
     return read_header(this->stream(), nullptr);
 }
 
 SkSwizzler* SkWbmpCodec::initializeSwizzler(const SkImageInfo& info, const SkPMColor* ctable,
         const Options& opts) {
-    // Create the swizzler based on the desired color type
-    switch (info.colorType()) {
-        case kIndex_8_SkColorType:
-        case kN32_SkColorType:
-        case kRGB_565_SkColorType:
-        case kGray_8_SkColorType:
-            break;
-        default:
-            return nullptr;
-    }
     return SkSwizzler::CreateSwizzler(SkSwizzler::kBit, ctable, info, opts);
 }
 
 bool SkWbmpCodec::readRow(uint8_t* row) {
     return this->stream()->read(row, fSrcRowBytes) == fSrcRowBytes;
 }
 
 SkWbmpCodec::SkWbmpCodec(const SkImageInfo& info, SkStream* stream)
     : INHERITED(info, stream)
     , fSrcRowBytes(get_src_row_bytes(this->getInfo().width()))
@@ skipping 10 matching lines @@
                                          size_t rowBytes,
                                          const Options& options,
                                          SkPMColor ctable[],
                                          int* ctableCount,
                                          int* rowsDecoded) {
     if (options.fSubset) {
         // Subsets are not supported.
         return kUnimplemented;
     }
 
-    if (!valid_alpha(info.alphaType(), this->getInfo().alphaType())) {
+    if (!valid_color_type(info.colorType(), info.alphaType()) ||
+            !valid_alpha(info.alphaType(), this->getInfo().alphaType())) {
         return kInvalidConversion;
     }
 
     // Prepare a color table if necessary
     setup_color_table(info.colorType(), ctable, ctableCount);
 
     // Initialize the swizzler
     SkAutoTDelete<SkSwizzler> swizzler(this->initializeSwizzler(info, ctable, options));
-    if (nullptr == swizzler.get()) {
-        return kInvalidConversion;
-    }
+    SkASSERT(swizzler);
 
     // Perform the decode
     SkISize size = info.dimensions();
     SkAutoTMalloc<uint8_t> src(fSrcRowBytes);
     void* dstRow = dst;
     for (int y = 0; y < size.height(); ++y) {
         if (!this->readRow(src.get())) {
             *rowsDecoded = y;
             return kIncompleteInput;
         }
@@ skipping 32 matching lines @@
     return count;
 }
 
 SkCodec::Result SkWbmpCodec::onStartScanlineDecode(const SkImageInfo& dstInfo,
         const Options& options, SkPMColor inputColorTable[], int* inputColorCount) {
     if (options.fSubset) {
         // Subsets are not supported.
         return kUnimplemented;
     }
 
-    if (!valid_alpha(dstInfo.alphaType(), this->getInfo().alphaType())) {
+    if (!valid_color_type(dstInfo.colorType(), dstInfo.alphaType()) ||
+            !valid_alpha(dstInfo.alphaType(), this->getInfo().alphaType())) {
         return kInvalidConversion;
     }
 
     // Fill in the color table
     setup_color_table(dstInfo.colorType(), inputColorTable, inputColorCount);
 
     // Copy the color table to a pointer that can be owned by the scanline decoder
     if (kIndex_8_SkColorType == dstInfo.colorType()) {
         fColorTable.reset(new SkColorTable(inputColorTable, 2));
     }
 
     // Initialize the swizzler
     fSwizzler.reset(this->initializeSwizzler(dstInfo, get_color_ptr(fColorTable.get()), options));
-    if (nullptr == fSwizzler.get()) {
-        return kInvalidConversion;
-    }
+    SkASSERT(fSwizzler);
 
     fSrcBuffer.reset(fSrcRowBytes);
 
     return kSuccess;
 }