Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1695393003: [es6] Implement for-of iterator finalization (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Disable iterator test for Ignition Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/parsing/rewriter.cc ('k') | test/mjsunit/harmony/destructuring.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/compiler.h" 7 #include "src/compiler.h"
8 #include "src/interpreter/bytecode-array-iterator.h" 8 #include "src/interpreter/bytecode-array-iterator.h"
9 #include "src/interpreter/bytecode-generator.h" 9 #include "src/interpreter/bytecode-generator.h"
10 #include "src/interpreter/interpreter.h" 10 #include "src/interpreter/interpreter.h"
(...skipping 6409 matching lines...) Expand 10 before | Expand all | Expand 10 after
6420 // clang-format on 6420 // clang-format on
6421 6421
6422 for (size_t i = 0; i < arraysize(snippets); i++) { 6422 for (size_t i = 0; i < arraysize(snippets); i++) {
6423 Handle<BytecodeArray> bytecode_array = 6423 Handle<BytecodeArray> bytecode_array =
6424 helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet); 6424 helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
6425 CheckBytecodeArrayEqual(snippets[i], bytecode_array); 6425 CheckBytecodeArrayEqual(snippets[i], bytecode_array);
6426 } 6426 }
6427 } 6427 }
6428 6428
6429 6429
6430 TEST(ForOf) { 6430 // TODO(rmcilroy): Do something about this; new bytecode is too large
6431 // (150+ instructions) to adapt manually.
6432 DISABLED_TEST(ForOf) {
6431 InitializedHandleScope handle_scope; 6433 InitializedHandleScope handle_scope;
6432 BytecodeGeneratorHelper helper; 6434 BytecodeGeneratorHelper helper;
6433 Zone zone; 6435 Zone zone;
6434 6436
6435 int array_literal_flags = 6437 int array_literal_flags =
6436 ArrayLiteral::kDisableMementos | ArrayLiteral::kShallowElements; 6438 ArrayLiteral::kDisableMementos | ArrayLiteral::kShallowElements;
6437 int object_literal_flags = 6439 int object_literal_flags =
6438 ObjectLiteral::kFastElements | ObjectLiteral::kDisableMementos; 6440 ObjectLiteral::kFastElements | ObjectLiteral::kDisableMementos;
6439 6441
6440 FeedbackVectorSpec feedback_spec(&zone); 6442 FeedbackVectorSpec feedback_spec(&zone);
(...skipping 2791 matching lines...) Expand 10 before | Expand all | Expand 10 after
9232 helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet); 9234 helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
9233 CheckBytecodeArrayEqual(snippets[i], bytecode_array); 9235 CheckBytecodeArrayEqual(snippets[i], bytecode_array);
9234 } 9236 }
9235 } 9237 }
9236 9238
9237 // TODO(oth): Add tests for super keyword. 9239 // TODO(oth): Add tests for super keyword.
9238 9240
9239 } // namespace interpreter 9241 } // namespace interpreter
9240 } // namespace internal 9242 } // namespace internal
9241 } // namespace v8 9243 } // namespace v8
OLDNEW
« no previous file with comments | « src/parsing/rewriter.cc ('k') | test/mjsunit/harmony/destructuring.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698