Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1695333003: SkOSFile_stdio: less :: (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
lsalzman1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkOSFile_stdio: less :: It's not clear why we wrote this file in this manner. On OpenBSD, fileno is a macro, so ::fileno makes no sense. Also remove some end-of-line whitespace. BUG=skia:4953 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1695333003 Committed: https://skia.googlesource.com/skia/+/944c2d901c5118abae2262f38414ccb939111355

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M src/ports/SkOSFile_stdio.cpp View 8 chunks +23 lines, -23 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695333003/1
4 years, 10 months ago (2016-02-16 15:45:15 UTC) #4
mtklein_C
4 years, 10 months ago (2016-02-16 15:47:57 UTC) #6
lsalzman1
lgtm Thanks for quick patch.
4 years, 10 months ago (2016-02-16 15:51:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695333003/1
4 years, 10 months ago (2016-02-16 15:52:11 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 16:10:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/944c2d901c5118abae2262f38414ccb939111355

Powered by Google App Engine
This is Rietveld 408576698