Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1695333002: PPC: Support immediate indices for StoreWriteBarrier. (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Support immediate indices for StoreWriteBarrier. Port 4eff883bcecaf24dfdcc6441e4558a9f5e69bd55 c72b49bddcf1484bf3553ea702cf1764690a33df Original commit message: Ideally we would not need the StoreWriteBarrier instructions at all, but represent the RecordWrite functionality as machine subgraph, but that'll take some time to get there. In the mean time we can have a shorter instruction sequence by recognizing immediate indices here. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/5ca122a12004c74979e85686c8b2d713890753ce Cr-Commit-Position: refs/heads/master@{#34006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -7 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 3 chunks +36 lines, -5 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
MTBrandyberry
4 years, 10 months ago (2016-02-15 18:08:26 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695333002/1
4 years, 10 months ago (2016-02-15 18:09:29 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-15 18:39:28 UTC) #5
dstence
lgtm
4 years, 10 months ago (2016-02-15 18:54:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695333002/1
4 years, 10 months ago (2016-02-15 18:57:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 19:00:43 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 19:01:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ca122a12004c74979e85686c8b2d713890753ce
Cr-Commit-Position: refs/heads/master@{#34006}

Powered by Google App Engine
This is Rietveld 408576698