Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1695293002: [turbofan] ARM: Use SBFX in instruction selector. (Closed)

Created:
4 years, 10 months ago by martyn.capewell
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] ARM: Use SBFX in instruction selector. Support SBFX in the instruction selector for sign-extension patterns like Sar(Shl(x, a), b), where a and b are immediate values. BUG= Committed: https://crrev.com/14a5c18cc35b2c55b37de3bd0ad27941cf21cb68 Cr-Commit-Position: refs/heads/master@{#34029}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +17 lines, -8 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
martyn.capewell
4 years, 10 months ago (2016-02-15 14:42:08 UTC) #3
Benedikt Meurer
Nice. LGTM.
4 years, 10 months ago (2016-02-16 05:08:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695293002/1
4 years, 10 months ago (2016-02-16 10:59:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 11:29:37 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 11:29:53 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14a5c18cc35b2c55b37de3bd0ad27941cf21cb68
Cr-Commit-Position: refs/heads/master@{#34029}

Powered by Google App Engine
This is Rietveld 408576698