Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1695243005: Update slot's m_distributedIndices correctly (Closed)

Created:
4 years, 10 months ago by hayato
Modified:
4 years, 10 months ago
Reviewers:
yuzuchan, kochi
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update slot's m_distributedIndices correctly This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slot's m_distributedIndices correctly. BUG=531990 Committed: https://crrev.com/13f1bb2f2cb780fe96dc43b0e96219dac5ba3cd6 Cr-Commit-Position: refs/heads/master@{#375824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695243005/1
4 years, 10 months ago (2016-02-17 05:17:13 UTC) #2
hayato
PTAL
4 years, 10 months ago (2016-02-17 05:31:38 UTC) #11
kochi
In what case m_distributedNodes and m_distributedIndices become different set of Nodes? I thought they have ...
4 years, 10 months ago (2016-02-17 06:02:56 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 06:24:24 UTC) #16
hayato
On 2016/02/17 06:02:56, kochi wrote: > In what case m_distributedNodes and m_distributedIndices > become different ...
4 years, 10 months ago (2016-02-17 07:56:56 UTC) #17
kochi
ah, I see. lgtm.
4 years, 10 months ago (2016-02-17 07:58:26 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695243005/1
4 years, 10 months ago (2016-02-17 08:04:07 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 08:11:31 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 08:12:36 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13f1bb2f2cb780fe96dc43b0e96219dac5ba3cd6
Cr-Commit-Position: refs/heads/master@{#375824}

Powered by Google App Engine
This is Rietveld 408576698