|
|
Created:
4 years, 10 months ago by hayato Modified:
4 years, 10 months ago CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate slot's m_distributedIndices correctly
This CL fixes a bug in https://codereview.chromium.org/1611413005.
In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices,
to update this slot's m_distributedIndices correctly.
BUG=531990
Committed: https://crrev.com/13f1bb2f2cb780fe96dc43b0e96219dac5ba3cd6
Cr-Commit-Position: refs/heads/master@{#375824}
Patch Set 1 #
Messages
Total messages: 24 (15 generated)
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695243005/1
Description was changed from ========== Use distributedNodes to update indices. BUG=531990 ========== to ========== Update slot's m_distributedIndices correctly Fix a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of m_distributedIndices. BUG=531990 ==========
Description was changed from ========== Update slot's m_distributedIndices correctly Fix a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of m_distributedIndices. BUG=531990 ========== to ========== Fix a wrong update of m_distributedIndices This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of m_distributedIndices. BUG=531990 ==========
Description was changed from ========== Fix a wrong update of m_distributedIndices This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of m_distributedIndices. BUG=531990 ========== to ========== Fix an incorrect update of slot's m_distributedIndices This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of m_distributedIndices. BUG=531990 ==========
Description was changed from ========== Fix an incorrect update of slot's m_distributedIndices This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of m_distributedIndices. BUG=531990 ========== to ========== Update slot's m_distributedIndices correctly This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of m_distributedIndices. BUG=531990 ==========
Description was changed from ========== Update slot's m_distributedIndices correctly This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of m_distributedIndices. BUG=531990 ========== to ========== Update slot's m_distributedIndices correctly This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slots' m_distributedIndices. BUG=531990 ==========
Description was changed from ========== Update slot's m_distributedIndices correctly This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slots' m_distributedIndices. BUG=531990 ========== to ========== Update slot's m_distributedIndices correctly. This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slots' m_distributedIndices. BUG=531990 ==========
Description was changed from ========== Update slot's m_distributedIndices correctly. This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slots' m_distributedIndices. BUG=531990 ========== to ========== Update slot's m_distributedIndices correctly. This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slots' m_distributedIndices, correctly. BUG=531990 ==========
hayato@chromium.org changed reviewers: + kochi@chromium.org, yuzus@chromium.org
PTAL
Description was changed from ========== Update slot's m_distributedIndices correctly. This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slots' m_distributedIndices, correctly. BUG=531990 ========== to ========== Update slot's m_distributedIndices correctly. This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slot's m_distributedIndices correctly. BUG=531990 ==========
Description was changed from ========== Update slot's m_distributedIndices correctly. This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slot's m_distributedIndices correctly. BUG=531990 ========== to ========== Update slot's m_distributedIndices correctly This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slot's m_distributedIndices correctly. BUG=531990 ==========
In what case m_distributedNodes and m_distributedIndices become different set of Nodes? I thought they have the same set of nodes.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/02/17 06:02:56, kochi wrote: > In what case m_distributedNodes and m_distributedIndices > become different set of Nodes? > I thought they have the same set of nodes. The order of the iteration matters here. m_distributedNodes is a vector. m_distributedIndices is a hash map.
ah, I see. lgtm.
The CQ bit was checked by hayato@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695243005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695243005/1
Message was sent while issue was closed.
Description was changed from ========== Update slot's m_distributedIndices correctly This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slot's m_distributedIndices correctly. BUG=531990 ========== to ========== Update slot's m_distributedIndices correctly This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slot's m_distributedIndices correctly. BUG=531990 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Update slot's m_distributedIndices correctly This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slot's m_distributedIndices correctly. BUG=531990 ========== to ========== Update slot's m_distributedIndices correctly This CL fixes a bug in https://codereview.chromium.org/1611413005. In HTMLSlotElement::appendDistributedFrom, we should use other.m_distributedNodes, instead of other.m_distributedIndices, to update this slot's m_distributedIndices correctly. BUG=531990 Committed: https://crrev.com/13f1bb2f2cb780fe96dc43b0e96219dac5ba3cd6 Cr-Commit-Position: refs/heads/master@{#375824} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/13f1bb2f2cb780fe96dc43b0e96219dac5ba3cd6 Cr-Commit-Position: refs/heads/master@{#375824} |