Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1695243002: [Swarming] Isolate perf tests. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Swarming] Isolate perf tests. This is to enable deduplicating performance tests. We'll create a hash of all relevant files and send it to perf bots alongside the other swarming hashes (follow up on infra side). This will not actually run on swarming yet, but could at some later point. This splits off the cctest executable from other verification test files, as those are not needed in performance tests. BUG=chromium:535160 LOG=n Committed: https://crrev.com/05218010cd59c688663351f322ba0f12ac438b9f Cr-Commit-Position: refs/heads/master@{#33989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -12 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 2 chunks +14 lines, -1 line 0 comments Download
M test/cctest/cctest.isolate View 1 chunk +2 lines, -3 lines 0 comments Download
A + test/cctest/cctest_exe.isolate View 1 chunk +3 lines, -4 lines 0 comments Download
A + test/perf.gyp View 1 chunk +4 lines, -4 lines 0 comments Download
A test/perf.isolate View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Michael Achenbach
PTAL
4 years, 10 months ago (2016-02-15 10:53:50 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695243002/1
4 years, 10 months ago (2016-02-15 10:54:48 UTC) #7
tandrii(chromium)
lgtm
4 years, 10 months ago (2016-02-15 11:04:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695243002/1
4 years, 10 months ago (2016-02-15 11:13:09 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 11:17:12 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 11:17:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05218010cd59c688663351f322ba0f12ac438b9f
Cr-Commit-Position: refs/heads/master@{#33989}

Powered by Google App Engine
This is Rietveld 408576698